Feat: add panel_group element and environment_card panel #5958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephanegigandet
added
the
📖 Knowledge Panels
teolemon
reviewed
Oct 11, 2021
po/common/common.pot
Outdated
| msgstr "Carbon footprint" | ||
|
|
||
| msgctxt "carbon_footprint_per_100g_of_product" | ||
| msgid "g CO² per 100g of product" |
There was a problem hiding this comment.
Can you use a placeholder for languages which change the order of words ?
Suggested change
| msgid "g CO² per 100g of product" | |
| msgid "%s g CO² per 100g of product" |
alexgarel
reviewed
Oct 11, 2021
|
Hello, possible to see a sample json response ? Can review the PR from API perspective, but probably better I leave the code review to Alex:) |
Hi @jasmeet0817 , yes, you can see it on the dev server (login and password: off ) : https://uk.openfoodfacts.dev/api/v2/product/3017620422003/nutella-ferrero?fields=knowledge_panels |
|
Kudos, SonarCloud Quality Gate passed!
|
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #5955 with a clean commit history.
--
Some changes discussed with Jasmeet, in order to build the Environment card as designed by Tim.
The environment card is going to be itself a knowledge panel, of a special type "card", which will make it shown expanded, and we can round corners etc.
In it we have elements that are panel groups: groups that contain multiple panels. For instance the "Labels" panel group may contain an organic panel + a fair trade panel. This is to be able to display "section names" like we have in the mockup.
Mockup:
Current web display: