Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove MONGO_INIT_ROOT_USERNAME/PASSWORD as it breaks the dev workflow" #6127

Merged
merged 2 commits into from
Nov 29, 2021
Merged

fix: remove MONGO_INIT_ROOT_USERNAME/PASSWORD as it breaks the dev workflow" #6127

merged 2 commits into from
Nov 29, 2021

Conversation

ocervell
Copy link
Collaborator

Checklist:

Make sure you've done all the following (You can delete the checklist before submitting)

  • Code is well documented
  • Include unit tests for new functionality
  • Code passes GitHub workflow checks in your branch
  • If you have multiple commits please combine them into one commit by squashing them.
  • Read and understood the contribution guidelines

Description:

Describe the changes made and why they were made instead of how they were made.

Related issues and discussion: #[ISSUE NUMBER]

@ocervell ocervell requested a review from a team as a code owner November 29, 2021 14:34
alexgarel
alexgarel reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yes, I was hit by this one !

@sonarcloud
Copy link

sonarcloud bot commented Nov 29, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexgarel
alexgarel approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM + tested ok.

@stephanegigandet stephanegigandet merged commit 494e0c5 into main Nov 29, 2021
@stephanegigandet stephanegigandet deleted the fix-mongodb-pw branch November 29, 2021 15:43
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
@teolemon teolemon added the MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products label May 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees
No one assigned
Labels
MongoDB We have 2 mongodb collections: one for current products, and one for obsolete products
Projects
old prs
Status: No status
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ocervell @alexgarel @teolemon @stephanegigandet