Remove circular dependencies in ProductOpener modules

[stephanegigandet]

What

• e.g. in Food.pm : use ProductOpener::Tags qw/:all/;
• in Tags.pm : use ProductOpener::Food qw/:all/;
• This can cause strange bugs depending on the order of the use clauses, modules initialized multiple times etc.
• We need to create a graph of the uses in Product Opener modules, and find ways to remove cycles.

Part of

• 🎯 What can I work on ? #5529

[hangy]

Meh, I tried graphing the dependencies with App:PrereqGrapher, but apparently it fails when I set depth to anything higher than 1 (when analyzing Display.pm) or if I try to analyze all of our *.pm files with a wildcard. I suppose it could just abort because of the circular dependency we want to avoid. 😆

[hangy]

I built this graph based on 501837d and the curent use statements, without testing whether any subs or variables are actually used: https://hangy.de/off/dependencies2.svg

GraphViz

digraph g{
  rankdir=LR;
  "ProductOpener::Cache" -> "ProductOpener::Store";
  "ProductOpener::Cache" -> "ProductOpener::Config";

  "ProductOpener::Config" -> "ProductOpener::Config2";

  "ProductOpener::Data" -> "ProductOpener::Config";

  "ProductOpener::Display" -> "ProductOpener::Store";
  "ProductOpener::Display" -> "ProductOpener::Config";
  "ProductOpener::Display" -> "ProductOpener::Tags";
  "ProductOpener::Display" -> "ProductOpener::TagsEntries";
  "ProductOpener::Display" -> "ProductOpener::Users";
  "ProductOpener::Display" -> "ProductOpener::Index";
  "ProductOpener::Display" -> "ProductOpener::Cache";
  "ProductOpener::Display" -> "ProductOpener::Lang";
  "ProductOpener::Display" -> "ProductOpener::Images";
  "ProductOpener::Display" -> "ProductOpener::Food";
  "ProductOpener::Display" -> "ProductOpener::Ingredients";
  "ProductOpener::Display" -> "ProductOpener::Products";
  "ProductOpener::Display" -> "ProductOpener::Missions";
  "ProductOpener::Display" -> "ProductOpener::MissionsConfig";
  "ProductOpener::Display" -> "ProductOpener::URL";
  "ProductOpener::Display" -> "ProductOpener::Data";

  "ProductOpener::Food" -> "ProductOpener::Store";
  "ProductOpener::Food" -> "ProductOpener::Config";
  "ProductOpener::Food" -> "ProductOpener::Lang";
  "ProductOpener::Food" -> "ProductOpener::Tags";

  "ProductOpener::Images" -> "ProductOpener::Store";
  "ProductOpener::Images" -> "ProductOpener::Config";
  "ProductOpener::Images" -> "ProductOpener::Products";
  "ProductOpener::Images" -> "ProductOpener::Lang";
  "ProductOpener::Images" -> "ProductOpener::Display";
  "ProductOpener::Images" -> "ProductOpener::URL";

  "ProductOpener::Import" -> "ProductOpener::Config";
  "ProductOpener::Import" -> "ProductOpener::Store";
  "ProductOpener::Import" -> "ProductOpener::Tags";

  "ProductOpener::Index" -> "ProductOpener::Config";
  "ProductOpener::Index" -> "ProductOpener::Store";
  "ProductOpener::Index" -> "ProductOpener::Tags";
  "ProductOpener::Index" -> "ProductOpener::Users";

  "ProductOpener::Ingredients" -> "ProductOpener::Store";
  "ProductOpener::Ingredients" -> "ProductOpener::Config";
  "ProductOpener::Ingredients" -> "ProductOpener::Users";
  "ProductOpener::Ingredients" -> "ProductOpener::Products";
  "ProductOpener::Ingredients" -> "ProductOpener::TagsEntries";
  "ProductOpener::Ingredients" -> "ProductOpener::Tags";
  "ProductOpener::Ingredients" -> "ProductOpener::URL";

  "ProductOpener::Lang" -> "ProductOpener::I18N";
  "ProductOpener::Lang" -> "ProductOpener::Config";
  "ProductOpener::Lang" -> "ProductOpener::Store";

  "ProductOpener::Mail" -> "ProductOpener::Store";
  "ProductOpener::Mail" -> "ProductOpener::Config";
  "ProductOpener::Mail" -> "ProductOpener::Lang";

  "ProductOpener::Missions" -> "ProductOpener::Store";
  "ProductOpener::Missions" -> "ProductOpener::Config";
  "ProductOpener::Missions" -> "ProductOpener::Users";
  "ProductOpener::Missions" -> "ProductOpener::Products";
  "ProductOpener::Missions" -> "ProductOpener::Display";
  "ProductOpener::Missions" -> "ProductOpener::MissionsConfig";
  "ProductOpener::Missions" -> "ProductOpener::Lang";
  "ProductOpener::Missions" -> "ProductOpener::Tags";

  "ProductOpener::MissionsConfig" -> "ProductOpener::Store";
  "ProductOpener::MissionsConfig" -> "ProductOpener::Config";
  "ProductOpener::MissionsConfig" -> "ProductOpener::Users";
  "ProductOpener::MissionsConfig" -> "ProductOpener::Products";
  "ProductOpener::MissionsConfig" -> "ProductOpener::Lang";

  "ProductOpener::Products" -> "ProductOpener::Store";
  "ProductOpener::Products" -> "ProductOpener::Config";
  "ProductOpener::Products" -> "ProductOpener::Users";
  "ProductOpener::Products" -> "ProductOpener::Display";
  "ProductOpener::Products" -> "ProductOpener::Lang";
  "ProductOpener::Products" -> "ProductOpener::Food";
  "ProductOpener::Products" -> "ProductOpener::Tags";
  "ProductOpener::Products" -> "ProductOpener::Mail";
  "ProductOpener::Products" -> "ProductOpener::URL";
  "ProductOpener::Products" -> "ProductOpener::Data";

  "ProductOpener::SiteQuality" -> "ProductOpener::Store";
  "ProductOpener::SiteQuality" -> "ProductOpener::Tags";

  "ProductOpener::Tags" -> "ProductOpener::Store";
  "ProductOpener::Tags" -> "ProductOpener::Config";
  "ProductOpener::Tags" -> "ProductOpener::TagsEntries";
  "ProductOpener::Tags" -> "ProductOpener::Food";
  "ProductOpener::Tags" -> "ProductOpener::Lang";
  "ProductOpener::Tags" -> "ProductOpener::Text";

  "ProductOpener::URL" -> "ProductOpener::Config";

  "ProductOpener::Users" -> "ProductOpener::Store";
  "ProductOpener::Users" -> "ProductOpener::Config";
  "ProductOpener::Users" -> "ProductOpener::Mail";
  "ProductOpener::Users" -> "ProductOpener::Lang";
  "ProductOpener::Users" -> "ProductOpener::Cache";
  "ProductOpener::Users" -> "ProductOpener::Display";
}

[stephanegigandet]

@hangy : I had missed the graph, wow. I did make quite a mess.