Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove obsolete strings & remove duplicate strings #6440

Merged
merged 6 commits into from
Mar 22, 2022
Merged

fix: remove obsolete strings & remove duplicate strings #6440

merged 6 commits into from
Mar 22, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Feb 24, 2022 •
edited

What

  • remove obsolete strings
  • remove duplicate strings

@teolemon teolemon requested a review from a team as a code owner February 24, 2022 18:58
@github-actions github-actions bot added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Feb 24, 2022
@teolemon teolemon changed the title remove-obsolete-strings fix: remove obsolete strings & remove duplicate strings Feb 24, 2022
@stephanegigandet
Copy link
Contributor

Why change those files manually instead of letting Crowdin manage them?

@teolemon
Copy link
Member Author

Good catch @stephanegigandet fixed

@sonarcloud
Copy link

sonarcloud bot commented Feb 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel
Copy link
Member

Do you still need approval on this @teolemon or should we close it ?

@stephanegigandet stephanegigandet merged commit 4a2dfd1 into main Mar 22, 2022
@stephanegigandet stephanegigandet deleted the remove-obsolete-strings branch March 22, 2022 09:48
@github-actions github-actions bot mentioned this pull request Mar 22, 2022
Merged
@teolemon teolemon self-assigned this Apr 1, 2022
@teolemon teolemon added this to the V1.1.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@teolemon teolemon

Labels
Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teolemon @stephanegigandet @alexgarel