Prevent people from entering email addresses as values

[teolemon]

What

• Prevent people from entering email addresses as values

Screenshots

Part of

• 🧽 Data quality (tracker) #5538

[stephanegigandet]

Files with the corresponding code:

Server-side:

cgi/product_multilingual.pl - web form to edit products
cgi/product_jqm_multilingual.pl - API
lib/ProductOpener/Products.pm

[yuktea]

working on this!

[github-actions]

This issue is stale because it has been open 90 days with no activity.

[MonalikaPatnaik]

I would like to work on this!

[alexgarel]

Relevant comment from old PR:

This would work, but as you suggest, we probably should think more about this, to decide what would be the right behaviour:

1. reject the changes completely if there is an error in one of the fields

2. ignore the fields that have errors

And how to convey this information to users so that they can correct the fields.

It's also complexified a bit by the fact that those changes can be made through the OFF website (and app), but also through third parties that use our API to add / edit products. It's relatively easy for us to introduce new behaviours on the website (such as redisplaying the form with messages about errors), but for the API, we need to find a solution that does not break existing applications that use the API.

[alexgarel]

My proposal to keep things simple (as a first iteration):

• just remove values that are email in fields and accept the rest of the edit (for single valued fields remove the field edit, for multi-valued fields just remove entries that are emails)
• on the web application add a warning thanks to javascript

That way we can do it in process_product_edit_rules (but in a separate method, it's already big).

(in fact process_product_edit_rules could be renamed to check_product_edit, that call both methods and still return a boolean).

[MonalikaPatnaik]

My proposal to keep things simple (as a first iteration):

• just remove values that are email in fields and accept the rest of the edit (for single valued fields remove the field edit, for multi-valued fields just remove entries that are emails)
• on the web application add a warning thanks to javascript

That way we can do it in process_product_edit_rules (but in a separate method, it's already big).

(in fact process_product_edit_rules could be renamed to check_product_edit, that call both methods and still return a boolean).

Working on this..will resolve it soon!
Thanyouu :-)