Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow displaying products with barcodes > 24 OR disallow barcode length greater than 24(?) #6571

Open
CharlesNepote opened this issue Apr 7, 2022 · 4 comments
Labels
barcodes 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@CharlesNepote
Copy link
Member

Describe the bug

Current situation:

To Reproduce

https://world.openfoodfacts.org/product/0105400141340210310300051/gouda-belegen-everyday%22 (the product exists, it is findable)

Expected behavior

I think products should be displayed, even if the barcode is wrong, at least to allow moderators to delete them, if necessary.

Screenshots

No response

Additional context

See also:

Type of device

Browser

Browser version

No response

Number of products impacted

No response

Time per product

No response

@CharlesNepote CharlesNepote added 🐛 bug This is a bug, not a feature request. barcodes 🧽 Data quality https://wiki.openfoodfacts.org/Quality labels Apr 7, 2022
@stephanegigandet stephanegigandet added the good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. label Apr 11, 2022
@manognyaa
Copy link

manognyaa commented Apr 14, 2022

hello, I am manognya, an outreachy applicant. I would like to work on this issue @stephanegigandet sir. So, the issue is like the products up to 24 only the scanner is taking the input. and remaining i.e. above 24 digits barcode, it is not accepting and displaying as an error. I would love to complete this issue. I have gone through the links provided in the issue template. @stephanegigandet sir, if you don't mind, could pls guide me further how to do it. I need help.

Thank you!

@alexgarel
Copy link
Member

@manognyaa it surely starts in display.pl, but this file is a little confusing, so you have to trace where it happens. The difficulty is that we did not work on setting up the debbugger yet…

But you can follow logs (make tail)

And you can edit the source code to add temporary debug logs (look at existing logs) - but remember to restart the server if you edit the code : docker-compose restart backend

@manognyaa
Copy link

@manognyaa it surely starts in display.pl, but this file is a little confusing, so you have to trace where it happens. The difficulty is that we did not work on setting up the debbugger yet…

But you can follow logs (make tail)

And you can edit the source code to add temporary debug logs (look at existing logs) - but remember to restart the server if you edit the code : docker-compose restart backend

thank you for the info. I will start working on it. If I face any issue, pls guide me, @alexgarel sir.

@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
barcodes 🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality good first issue Welcome to Open Food Facts. This issue should be approachable if you're new. Get in touch for help. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Development

No branches or pull requests

4 participants