Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The WHO source links of the salt knowledge panels are not localized #7204

Open
Tracked by #8919
teolemon opened this issue Aug 15, 2022 · 1 comment
Open
Tracked by #8919

The WHO source links of the salt knowledge panels are not localized #7204

teolemon opened this issue Aug 15, 2022 · 1 comment
Labels
🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🐛 bug This is a bug, not a feature request. ✨ Feature Features or enhancements to Open Food Facts server 🌐 i18n Regarding software localization 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧂 Salt Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings

Comments

@teolemon
Copy link
Member

teolemon commented Aug 15, 2022 •
edited

Problem description

The salt knowledge panels are not localized in the handful of languages (العربية, 中文, Français, Русский, Español) available on the WHO website

Desired solution

openfoodfacts-server/templates/api/knowledge-panels/health/nutrition/nutrient_level.tt.json

Line 47 in 4699f67

"source_text": "World Health Organization (WHO) - Fact sheet - Salt reduction",

We could

Number of products impacted

appr. 100%

image

Part of
@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 🐛 bug This is a bug, not a feature request. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings 🤳🥫 mobile apps 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels Aug 15, 2022
@stephanegigandet stephanegigandet changed the title The salt knowledge panels are not localized The WHO source links of the salt knowledge panels are not localized Aug 18, 2022
@stephanegigandet
Copy link
Contributor

It's a good idea to add links to the 5 translated languages on the WHO website, but I would not force automated translation for the other languages. It's best to let users (or the browser preferences they have set) choose.

@teolemon teolemon added the 🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps label Oct 16, 2022
@teolemon teolemon added the Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. label Oct 31, 2022
@teolemon teolemon mentioned this issue Dec 4, 2022
Open
@teolemon teolemon added 🌐 i18n Regarding software localization and removed 🤳🥫 mobile apps labels Jun 8, 2023
@teolemon teolemon mentioned this issue Aug 28, 2023
Open
@teolemon teolemon added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels and removed 📖 Knowledge Panels - https://wiki.openfoodfacts.org/Knowledge_panels labels Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🤳🥫 blocking mobile apps This issues are blocking a feature on the Open Food Facts mobile apps 🐛 bug This is a bug, not a feature request. ✨ Feature Features or enhancements to Open Food Facts server 🌐 i18n Regarding software localization 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🧂 Salt Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org untranslatable strings
Projects
🌍 - Internationalization
Status: 🆕 New
🍊 Open Food Facts Server issues
Status: To discuss and validate
📖 Knowledge panels
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @stephanegigandet