fix: mongodb _id must be a string #7255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
alexgarel
reviewed
Aug 29, 2022
| # see bug #1077 - https://github.com/openfoodfacts/openfoodfacts-server/issues/1077 | ||
| # make sure that code is saved as a string, otherwise mongodb saves it as number, and leading 0s are removed | ||
| $product_ref->{code} = $product_ref->{code} . ''; | ||
| $product_ref->{_id} .= ''; | ||
| $product_ref->{code} .= ''; | ||
| $products_collection->replace_one({"_id" => $product_ref->{_id}}, $product_ref, { upsert => 1 }); |
There was a problem hiding this comment.
Should'nt we refactor and have an upsert_product function that ensure this kind of thing ? (Instead of using replace_one directly). This may help avoiding this error and maybe others ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an issue for barcode changes, the mongodb _id field got a number long type instead of a string.
This:
Once deployed, we need to:
run ./update_all_products.pl --fix-non-string
issue the MongoDB command indicated at the end of the script run:
products stored in MongoDB with a non string _id have been reloaded from .sto files (if the products still exist) and stored with a string _id.
products with non string ids can now be deleted from MongoDB with this command:
db.products.remove({_id : { $type : "long" }})
Fixes #4667