Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put back symlinks for cgi/product.pl #7302

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Conversation

stephanegigandet
Copy link
Contributor

I made a mistake while changing param() to single_param(). I used a sed command which replaced the symlinks by copies of the files... (in this commit: e04d343 )

This PR puts back symlinks.

@alexgarel
Copy link
Member

oooh I didn't understood while it was showing those file as completely changed, and forgot to ask you… now I understand

@alexgarel
Copy link
Member

@stephanegigandet you have perltidy issues, a make lint_perltidy should fix that

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but you have to fix you perltidy errors :-) make perltidy_lint

@sonarcloud
Copy link

sonarcloud bot commented Sep 6, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit c49176e into main Sep 7, 2022
@stephanegigandet stephanegigandet deleted the fix-symlinks branch September 7, 2022 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

2 participants