Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Label parenting #7321

Merged
merged 10 commits into from
Oct 6, 2022
Merged

fix: Label parenting #7321

merged 10 commits into from
Oct 6, 2022

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Sep 10, 2022

What

Repaired some wrong parenting.

Should these not have been intercepted by a test?

@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Sep 10, 2022
@aleene aleene changed the title bug: Label parenting fix: Label parenting Sep 10, 2022
@stephanegigandet
Copy link
Contributor

Repaired some wrong parenting.

Should these not have been intercepted by a test?

For parenting, the taxonomy building still works if you use a synonym or a translated name for the parent.

@@ -798,7 +798,7 @@ bg:Без пшеница
de:Ohne Weizen
nl:Zonder graan

en:No gluten, Gluten-free, Without gluten, Gluten-free-food, free of gluten, Naturally gluten free, Gluten free, ni gluten
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For allergens, antibiotics etc. the ingredients parsing code expects the "No something" to be the canonical entry.

There's a comment about that at the top of the file:

# For labels that indicate the absence of something, in English, always make "No something" the first entry, and make "Something-free", "Without something" synonyms

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we can add that it's required by the ingredients parsing code.

@alexgarel
Copy link
Member

@stephanegigandet what is the status on this PR ?

@aleene
Copy link
Contributor Author

aleene commented Oct 4, 2022

I think I have to revert some changes and adapt the children instead.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@stephanegigandet stephanegigandet merged commit ff2c778 into main Oct 6, 2022
@stephanegigandet stephanegigandet deleted the aleene-labels-parents branch October 6, 2022 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants