Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: default redis url to empty and handle reconnects #7540

Merged
merged 7 commits into from
Oct 14, 2022
Merged

fix: default redis url to empty and handle reconnects #7540

merged 7 commits into from
Oct 14, 2022

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Oct 13, 2022 •
edited

As in dev people don't necessarily have openfoodfacts-search running

We also changed lib to Redis which is better maintained, and handle connection timeout.

@alexgarel alexgarel requested a review from a team as a code owner October 13, 2022 14:36
@alexgarel alexgarel changed the title build: default redis url to empty fix default redis url to empty and handle reconnects Oct 13, 2022
@alexgarel alexgarel changed the title fix default redis url to empty and handle reconnects fix: default redis url to empty and handle reconnects Oct 13, 2022
@alexgarel
Copy link
Member Author

FYI @simonj2

@alexgarel
build: default redis url to empty
eb89e3b 
As in dev people don't necessarily have openfoodfacts-search running
@alexgarel
fix: change redis lib
45b7e37 
and better (not perfect) handling of redis connection
stephanegigandet
stephanegigandet approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but suggested a way to make the code easier to understand.

stephanegigandet
stephanegigandet approved these changes Oct 14, 2022
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thank you!

@sonarcloud
Copy link

sonarcloud bot commented Oct 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit ced62e8 into main Oct 14, 2022
@alexgarel alexgarel deleted the ag-fix-redis-default-url branch October 14, 2022 17:55
@alexgarel alexgarel mentioned this pull request Oct 14, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@alexgarel alexgarel

Labels
Products
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alexgarel @stephanegigandet