Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: add "Prix Juste Producteur" label #7751

Merged
merged 3 commits into from
Nov 25, 2022

Conversation

olivier5741
Copy link
Contributor

What

I added the label Prix Juste Producteur because it was missing and I want to add a product with this label

Hi there, this is my first commit. Since this is small change, I didn't run github action flow on my fork and didn't squash the commits (the repo is so big ... still not loaded on my machine ... didn't find how to squash online)

@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Nov 22, 2022
@olivier5741 olivier5741 changed the title taxonomy add "Prix Juste Producteur" label taxonomy: add "Prix Juste Producteur" label Nov 22, 2022
taxonomies/labels.txt Outdated Show resolved Hide resolved
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@olivier5741 thanks for the PR.

  • the name of the image have to match the name of the taxonomy entry, thus it should be named: prix-juste-producteur.80x80.png (otherwise it wont work).
  • it would be better if you can find a svg version of the logo
  • as a png it should be a 90 px height image (to keep the design consistent).

@olivier5741
Copy link
Contributor Author

@olivier5741 thanks for the PR.

  • the name of the image have to match the name of the taxonomy entry, thus it should be named: prix-juste-producteur.80x80.png (otherwise it wont work).
  • it would be better if you can find a svg version of the logo
  • as a png it should be a 90 px height image (to keep the design consistent).

I asked to get an SVG or 90x90 to the label authority (couldn't find it by browsing). I'll modify the file name according to what I get ;)

@olivier5741
Copy link
Contributor Author

I just resized an image I could find in the meantime, will see if the label authority replies later on with a better one ...

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet
Copy link
Contributor

@alexgarel I think we can merge, can you approve the changes?

olivier5741 and others added 2 commits November 24, 2022 19:58
Add Prix Juste Producteur label (image only)

Add Prix Juste Producteur label (text only)

remove child of mistake

Label Prix juste Producteur : Official authority

Label Prix Juste Producteur : replace image

Co-Authored-By: Alex Garel <alex@garel.org>
@alexgarel alexgarel self-requested a review November 25, 2022 18:09
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you :-)

@sonarcloud
Copy link

sonarcloud bot commented Nov 25, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 55f2f40 into openfoodfacts:main Nov 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants