Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow setting the packagings_complete field through API v3 #7856

Merged
merged 5 commits into from
Dec 19, 2022
Merged

feat: allow setting the packagings_complete field through API v3 #7856

merged 5 commits into from
Dec 19, 2022

Conversation

stephanegigandet
Copy link
Contributor

We have a field called packagings_complete that takes value 0 or 1 to indicate if the packagings field contains all element of the product.
This PR adds it to the API v3 WRITE product.

@stephanegigandet stephanegigandet requested a review from a team as a code owner December 16, 2022 15:29
@github-actions github-actions bot added API v3 API WRITE WRITE API to allow sending product info and image 📚 Documentation Documentation issues improve the project for everyone. 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org labels Dec 16, 2022
alexgarel
alexgarel approved these changes Dec 19, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great !

@sonarcloud
Copy link

sonarcloud bot commented Dec 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit fec330a into main Dec 19, 2022
@alexgarel alexgarel deleted the packagings-complete branch December 19, 2022 15:15
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 19, 2022
Merged
@teolemon teolemon mentioned this pull request Dec 26, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@stephanegigandet stephanegigandet

Labels
API v3 API WRITE WRITE API to allow sending product info and image 📚 Documentation Documentation issues improve the project for everyone. 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stephanegigandet @alexgarel