Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ingredient analysis translations #7908

Merged
merged 6 commits into from
May 17, 2023
Merged

feat: ingredient analysis translations #7908

merged 6 commits into from
May 17, 2023

Conversation

teolemon
Copy link
Member

What

feat: ingredient analysis translations

@github-actions github-actions bot added the 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies label Dec 25, 2022
@alexgarel
Copy link
Member

@teolemon is this a draft or a PR ?

@teolemon
Copy link
Member Author

teolemon commented Jan 4, 2023

I'm not fluent in all those languages. Other than that, PR

@teolemon teolemon marked this pull request as ready for review January 4, 2023 14:55
@alexgarel
Copy link
Member

I will fix tests.

@alexgarel alexgarel requested a review from a team as a code owner January 6, 2023 17:56
@sonarcloud
Copy link

sonarcloud bot commented Jan 6, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel
Copy link
Member

@teolemon there are problems with this PR:

ERROR - ar:نباتي already is associated to en:vegan - ar:نباتي cannot be mapped to entry en:vegetarian
ERROR - el:χορτοφάγος already is associated to en:vegan - el:χορτοφάγος cannot be mapped to entry en:vegetarian
ERROR - th:มังสวิรัติ already is associated to en:vegan - th:มังสวิรัติ cannot be mapped to entry en:vegetarian
ERROR - zh:素食主义者 already is associated to en:vegan - zh:素食主义者 cannot be mapped to entry en:vegetarian
ERROR - ar:ربما-نباتي already is associated to en:maybe-vegan - ar:ربما-نباتي cannot be mapped to entry en:maybe-vegetarian
ERROR - th:อาจจะเป็นมังสวิรัติ already is associated to en:maybe-vegan - th:อาจจะเป็นมังสวิรัติ cannot be mapped to entry en:maybe-vegetarian
ERROR - zh:也许是素食主义者 already is associated to en:maybe-vegan - zh:也许是素食主义者 cannot be mapped to entry en:maybe-vegetarian
ERROR - th:มังสวิรัติ already is associated to en:vegan - th:มังสวิรัติ cannot be mapped to entry en:non-vegetarian
Errors in the ingredients_analysis taxonomy definition at /opt/product-opener/lib/ProductOpener/Tags.pm line 1145.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Apr 7, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator

benbenben2 commented May 12, 2023 •
edited

Errors due to duplicates have been fixed @teolemon @alexgarel

alexgarel
alexgarel approved these changes May 17, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @benbenben2 👏

@alexgarel alexgarel merged commit 9561506 into main May 17, 2023
14 checks passed
@alexgarel alexgarel deleted the nova-taxo branch May 17, 2023 08:55
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request May 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@stephanegigandet stephanegigandet Awaiting requested review from stephanegigandet

Assignees

@teolemon teolemon

Labels
⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@teolemon @alexgarel @benbenben2