Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: added sugars for non US countries #7982

Merged
merged 2 commits into from
Jan 19, 2023
Merged

fix: added sugars for non US countries #7982

merged 2 commits into from
Jan 19, 2023

Conversation

stephanegigandet
Copy link
Contributor

fixes #7981

@stephanegigandet stephanegigandet requested a review from a team as a code owner January 13, 2023 12:09
aleene
aleene previously requested changes Jan 13, 2023
View reviewed changes
Copy link
Contributor

@aleene aleene left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add "added-salt" as well?

@stephanegigandet
Copy link
Contributor Author

Can you add "added-salt" as well?

Are there nutrition table on products with "added salt"? I'm guessing that in most products with a significant amount of salt, almost of it could be considered "added".

@aleene
Copy link
Contributor

aleene commented Jan 13, 2023

All products by Albert Heijn (largest supermarket) in NL have this as part of their ingredient list.

@stephanegigandet
Copy link
Contributor Author

image

@stephanegigandet
Copy link
Contributor Author

@aleene sounds good, I added "added salt", can you approve the PR?

@sonarcloud
Copy link

sonarcloud bot commented Jan 16, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet dismissed aleene’s stale review January 19, 2023 10:33

changes have been addressed

@stephanegigandet stephanegigandet merged commit a2871ee into main Jan 19, 2023
@stephanegigandet stephanegigandet deleted the added-sugars branch January 19, 2023 10:33
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jan 19, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@aleene aleene aleene left review comments

Assignees

@stephanegigandet stephanegigandet

Labels
Food.pm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Added sugars" is not suggested in the nutrition table product edit form
3 participants
@stephanegigandet @aleene @alexgarel