Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: responsive-scroll-bar #8196

Merged
merged 1 commit into from
Mar 14, 2023
Merged

fix: responsive-scroll-bar #8196

merged 1 commit into from
Mar 14, 2023

Conversation

MonalikaPatnaik
Copy link
Collaborator

What

In edit mode, the scroll to top button is overlapping with the changes summary textbox when the width of device is below 1024px. So, I have added media queries specifying the max-width to 1024px where the bottom margin of the button is set to 50px to prevent overlapping:)

Screenshot

Screenshot 2023-03-14 023630

Related issue(s) and discussion

@sonarcloud
Copy link

sonarcloud bot commented Mar 13, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@MonalikaPatnaik MonalikaPatnaik changed the title fix:responsive-scroll-bar fix: responsive-scroll-bar Mar 13, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect, thank you!

@stephanegigandet stephanegigandet merged commit 65f8415 into openfoodfacts:main Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NEW DESIGN - The go up button in edit mode should not overlap with the change summary
2 participants