Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: re-canonicalize packaging component properties #8246

Merged
merged 1 commit into from
Mar 24, 2023

Conversation

stephanegigandet
Copy link
Contributor

This is needed because we have changed the canonical names for packaging entries like PET.

@stephanegigandet stephanegigandet requested a review from a team as a code owner March 24, 2023 14:28
@github-actions github-actions bot added 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests labels Mar 24, 2023
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@github-advanced-security
Copy link

You have successfully added a new SonarCloud configuration ``. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

@stephanegigandet stephanegigandet merged commit 4668488 into main Mar 24, 2023
@stephanegigandet stephanegigandet deleted the canonicalize_packagings branch March 24, 2023 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants