Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data quality knowledge panel is not displayed when there are no errors #8294

Closed
CharlesNepote opened this issue Apr 7, 2023 · 1 comment · Fixed by #8745
Closed

Data quality knowledge panel is not displayed when there are no errors #8294

CharlesNepote opened this issue Apr 7, 2023 · 1 comment · Fixed by #8745
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@CharlesNepote
Copy link
Member

CharlesNepote commented Apr 7, 2023 •
edited
Loading

Describe the bug

image

  1. When there is no data quality error, "Contribution" section, data quality warnings ("Potential issues") and data quality info ("Data quality infos") are not displayed.
  2. I think it would be interesting to highlight (in green?) that there is "No data quality issues".

To Reproduce

  1. Open a product with a data quality error.
  2. Fix it and "Save"
  3. See the "Changes saved" screen.
@CharlesNepote CharlesNepote added the 🐛 bug This is a bug, not a feature request. label Apr 7, 2023
@CharlesNepote CharlesNepote changed the title Data quality knowledge panel is not displayed there are no errors Data quality knowledge panel is not displayed when there are no errors Apr 7, 2023
@CharlesNepote CharlesNepote added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Apr 11, 2023
@github-actions
Copy link
Contributor

This issue is stale because it has been open 90 days with no activity.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jul 11, 2023
@alexgarel alexgarel mentioned this issue Jul 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
📖 Knowledge panels
Status: To do
🧽 Ensuring Data Quality
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: always display contribution panel after edit openfoodfacts/openfoodfacts-server
1 participant
@CharlesNepote