Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: add demain-la-terre and sans-residus-de-pesticides-collectif-nouveaux-champs labels #8315

Merged
merged 2 commits into from
Apr 14, 2023
Merged

taxonomy: add demain-la-terre and sans-residus-de-pesticides-collectif-nouveaux-champs labels #8315

merged 2 commits into from
Apr 14, 2023

Conversation

benbenben2
Copy link
Collaborator

Solves #8310 and #8311

@benbenben2 benbenben2 requested a review from a team as a code owner April 12, 2023 16:19
@benbenben2 benbenben2 self-assigned this Apr 12, 2023
@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels Apr 12, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8315 (d094f15) into main (98625ff) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8315   +/-   ##
=======================================
  Coverage   47.06%   47.06%           
=======================================
  Files         109      109           
  Lines       20991    20991           
  Branches     4739     4739           
=======================================
  Hits         9880     9880           
  Misses       9942     9942           
  Partials     1169     1169

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2
Copy link
Collaborator Author

Tested on Gitpod
image

Question: is the line xx:<label name> useful? (I replaced http://fr. by http://world before to take the screenshot)

stephanegigandet
stephanegigandet approved these changes Apr 14, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@stephanegigandet stephanegigandet merged commit 224d686 into main Apr 14, 2023
@stephanegigandet stephanegigandet deleted the add_2_FR_labels branch April 14, 2023 09:29
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Apr 14, 2023
Merged
This was referenced Apr 14, 2023
Closed
Closed
@alexgarel
Copy link
Member

Thank you @benbenben2, you help us being more reactive :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@benbenben2 benbenben2

Labels
labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benbenben2 @codecov-commenter @alexgarel @stephanegigandet