Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: non-vegetarian Brown Triangle India #8410

Merged
merged 1 commit into from
May 23, 2023
Merged

Conversation

stephanegigandet
Copy link
Contributor

From krishanti on Slack:
https://openfoodfacts.slack.com/archives/C03RV686Y/p1683355107829579

"I've been adding new products & loving the nutrition analysis. I've also blogged about my experience here - https://mvark.blogspot.com/2023/05/openfoodfactsorg-wikipedia-of-food.html
While I respect the diversity offered which in turn offers useful insights on food choices across the globe, I hope the website adapts to make it more usable for Indians as there is a great need for food and nutritional awareness.
While it is great to see the green dot symbol (lacto-vegetarian food) being tracked, I suggest that the reddish-brown triangle symbol (it was a red dot earlier) which identifies non-vegetarian food be tracked as well while collecting data.
In 2021, FSSAI (Food Safety and Standards Authority of India) adopted a new symbol for non-vegetarian food items due to concerns that the combination of the old symbols were difficult for people with colour blindness to distinguish - https://en.wikipedia.org/wiki/Vegetarian_and_vegan_symbolism "

@stephanegigandet stephanegigandet requested a review from a team as a code owner May 11, 2023 15:11
@github-actions github-actions bot added labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels May 11, 2023
@sonarcloud
Copy link

sonarcloud bot commented May 11, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@teolemon teolemon added 🌱 Vegan 🇮🇳 India https://in.openfoodfacts.org labels May 11, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #8410 (5545d91) into main (a0cfac9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8410   +/-   ##
=======================================
  Coverage   48.46%   48.46%           
=======================================
  Files         114      114           
  Lines       21268    21268           
  Branches     4768     4768           
=======================================
  Hits        10308    10308           
  Misses       9677     9677           
  Partials     1283     1283           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2
Copy link
Collaborator

benbenben2 commented May 11, 2023

Do you think that we could make a parent?
Could it be better to split triangle and dot?

I am wondering if there is something wrong with synonyms... see screenshots

Shows old logo
image

Does not show new logo
image

<en:Vegetarian
en:indian vegetarian mark
wikidata:en:Q7918353

<en:indian vegetarian mark
<en:Vegetarian
en:Green Dot India, India Green Dot, Indian Green Dot, vegetarian mark India
image:en:green-dot-india.90x90.png
description:en:Packaged food and toothpaste products sold in India are required to be labelled with a mandatory mark in order to be distinguished between lacto-vegetarian and non-vegetarian.
label_categories:en: en:Specific diets

<en:indian vegetarian mark
<en:Non-vegetarian
en:Brown Triangle India, India Brown Triangle, Indian brown triangle, non-vegetarian mark india
image:en:brown-triangle-india.90x90.png
description:en:Packaged food and toothpaste products sold in India are required to be labelled with a mandatory mark in order to be distinguished between lacto-vegetarian and non-vegetarian. Products that contain eggs are considered non vegetarian by the FSSAI
label_categories:en: en:Specific diets

<en:indian vegetarian mark
<en:Non-vegetarian
en:Brown Dot India, India Brown dot, indian brown dot, brown dot
image:en:brown-dot-india.90x90.png
description:en:Packaged food and toothpaste products sold in India are required to be labelled with a mandatory mark in order to be distinguished between lacto-vegetarian and non-vegetarian. The brown dot is now a brown triangle.
label_categories:en: en:Specific diets

@stephanegigandet
Copy link
Contributor Author

Do you think that we could make a parent? Could it be better to split triangle and dot?

It depends if we consider that the brown triangle is just a design change of the brown dot, in which case it makes sense to show the brown triangle even if the product had a brown dot. That's why I made it a synonym.

The other option is to have 2 separate entries, for the brown dot and for the brown triangle.

Both make sense I think. We could start with 2 separate entries, and later we can always them merge them if needed.

Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It depends if we consider that the brown triangle is just a design change of the brown dot, in which case it makes sense to show the brown triangle even if the product had a brown dot. That's why I made it a synonym.

Fine for me to keep it as synonym. Seems we can have different logo depending of the synonym written, even though they are on the same line.

I suggest to put a common parent for both: "en:indian vegetarian mark" (see the snippet in my last message)
Not sure why some synonyms are not showing the logo (see screenshot above)

@alexgarel alexgarel merged commit d7fd285 into main May 23, 2023
15 checks passed
@alexgarel alexgarel deleted the brown-triangle branch May 23, 2023 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🇮🇳 India https://in.openfoodfacts.org labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🌱 Vegan
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants