feat: Run user deletion as a background task #8516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Minion
🏭 Producers Platform
stephanegigandet
approved these changes
Jun 5, 2023
There was a problem hiding this comment.
Wonderful, thank you.
The only thing is for the .po files: in practice we need only to change en.po and common.pot, as the other files will be populated by PRs made through Crowdin. In practice Product Opener uses the English translation if there's no translation in a local language. Could you remove the changes to the other .po files? Otherwise it will create lots of diffs (most of them will be removed unless we already have a translation) in the next Crowdin update.
|
Kudos, SonarCloud Quality Gate passed!
|
MonalikaPatnaik
pushed a commit
to aadak99/openfoodfacts-server
that referenced
this pull request
Jun 8, 2023
* Make user deletion a minion job * Change message * Change way enqueue is called to avoid issues with tests * Perltidy fix * Rever PO file changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
User deletion is run as a minion job rather than synchronously
Related issue(s) and discussion