feat: Allow users to delete their own accounts

[john-gom]

What

Enable account deletion for regular users with suitable warnings

Screenshot

Related issue(s) and discussion

• Fixes Allow to initiate account deletion from the website/API #6435

[stephanegigandet]

Looks good, thank you!

From @alexgarel on Slack:

"I would really have liked to have a separate DELETE button if possible, the delete checkbox with "save" is a bit difficult to understand I think !
But I know it might be difficult because of the way the code is written"

[stephanegigandet]

Having a separate Delete button should be relatively easy to add through the template I think.

[john-gom]

Having a separate Delete button should be relatively easy to add through the template I think.

I've just pushed a change to do this

[codecov-commenter]

Codecov Report

Merging #8548 (6460fc8) into main (2dee723) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8548   +/-   ##
=======================================
  Coverage   48.70%   48.70%           
=======================================
  Files         114      114           
  Lines       21412    21412           
  Branches     4789     4789           
=======================================
  Hits        10429    10429           
  Misses       9698     9698           
  Partials     1285     1285           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stephanegigandet]

I've just pushed a change to do this

Thanks @john-gom

Maybe we could put the "Danger zone" after the regular "Save" button:

(maybe with an extra
or 2 or a css style to separate well the danger zone from the rest of the form).

What do you think?

[john-gom]

I've just pushed a change to do this

Thanks @john-gom

Maybe we could put the "Danger zone" after the regular "Save" button:

(maybe with an extra or 2 or a css style to separate well the danger zone from the rest of the form).

What do you think?

Hi @stephanegigandet

Very easy to do but when I look at it I'm a bit concerned as the "call to action" for a form is typically at the bottom so I think having delete there could result in it being more likely to be clicked.

Cosmetically I also prefer having the group boxes together rather than having the save button in-between them

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

[stephanegigandet]

Thank you very much!