Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load both ciqual + calnut tables #8702

Merged
merged 4 commits into from
Jul 19, 2023
Merged

fix: load both ciqual + calnut tables #8702

merged 4 commits into from
Jul 19, 2023

Conversation

stephanegigandet
Copy link
Contributor

originally we loaded only the "extended" calnut table, which has estimates for all nutrients, but it is missing some categories, so we also load the normal ciqual table

@stephanegigandet stephanegigandet requested a review from a team as a code owner July 18, 2023 14:38
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 tests labels Jul 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 18, 2023

Codecov Report

Merging #8702 (bc42c4a) into main (2f186c1) will increase coverage by 0.07%.
The diff coverage is 86.66%.

@@            Coverage Diff             @@
##             main    #8702      +/-   ##
==========================================
+ Coverage   48.75%   48.82%   +0.07%     
==========================================
  Files         117      117              
  Lines       21823    21866      +43     
  Branches     4858     4866       +8     
==========================================
+ Hits        10639    10676      +37     
- Misses       9886     9887       +1     
- Partials     1298     1303       +5     
Impacted Files Coverage Δ
tests/unit/nutrition_estimation.t 86.36% <ø> (ø)
lib/ProductOpener/NutritionCiqual.pm 87.50% <86.66%> (-1.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Jul 18, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool

@alexgarel alexgarel merged commit e449fa8 into main Jul 19, 2023
14 checks passed
@alexgarel alexgarel deleted the ciqual-categories branch July 19, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🥗 Ingredients 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants