Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: added Croatian ingredients in taxonomies #8719

Merged
merged 2 commits into from
Jul 25, 2023
Merged

taxonomy: added Croatian ingredients in taxonomies #8719

merged 2 commits into from
Jul 25, 2023

Conversation

benbenben2
Copy link
Collaborator

What

added Croatian ingredients into the taxonomies.

(remark: big block "en:chokeberry" has been deleted because it was duplicated in the taxonomy)

@benbenben2 benbenben2 requested a review from a team as a code owner July 23, 2023 11:23
@benbenben2 benbenben2 self-assigned this Jul 23, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🧪 additives 🥜 Allergens labels 🧪 tests 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients - processing labels Jul 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 23, 2023 •
edited

Codecov Report

Merging #8719 (beb3d10) into main (6bdb35b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8719   +/-   ##
=======================================
  Coverage   48.82%   48.82%           
=======================================
  Files         117      117           
  Lines       21866    21866           
  Branches     4866     4866           
=======================================
  Hits        10676    10676           
  Misses       9887     9887           
  Partials     1303     1303
Files Changed Coverage Δ
lib/ProductOpener/Ingredients.pm 90.80% <ø> (ø)
tests/unit/ingredients_processing.t 94.73% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

stephanegigandet
stephanegigandet reviewed Jul 24, 2023
View reviewed changes
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good to me, just one comment on missing %

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@stephanegigandet stephanegigandet merged commit 1a8a5fa into main Jul 25, 2023
14 checks passed
@stephanegigandet stephanegigandet deleted the tax_hr_unknown_ingred_3 branch July 25, 2023 07:38
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Jul 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stephanegigandet stephanegigandet stephanegigandet approved these changes

Assignees

@benbenben2 benbenben2

Labels
🧪 additives 🥜 Allergens 🥗 Ingredients - processing 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@benbenben2 @codecov-commenter @stephanegigandet