Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Allowing Org Admins to Add/Invite Users #8763

Conversation

MonalikaPatnaik
Copy link
Collaborator

@MonalikaPatnaik MonalikaPatnaik commented Jul 31, 2023

What

Allowing Org admins to add/invite users to their organization..
for users that does not have off account, as of now we tell the org admin that we don’t have an user matching some of the emails

Screenshot

image

image

Related issue(s) and discussion

  • Fixes #[ISSUE NUMBER]

@github-actions github-actions bot added 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 👥 Users labels Jul 31, 2023
Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :)

@MonalikaPatnaik MonalikaPatnaik marked this pull request as ready for review August 4, 2023 11:15
@MonalikaPatnaik MonalikaPatnaik requested a review from a team as a code owner August 4, 2023 11:15
cgi/org.pl Outdated Show resolved Hide resolved
cgi/org.pl Outdated Show resolved Hide resolved
@github-actions github-actions bot added the Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org label Aug 10, 2023
cgi/org.pl Outdated Show resolved Hide resolved
cgi/org.pl Outdated Show resolved Hide resolved
MonalikaPatnaik and others added 4 commits August 11, 2023 20:51
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org>
@sonarcloud
Copy link

sonarcloud bot commented Aug 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@stephanegigandet stephanegigandet merged commit e2494e6 into openfoodfacts:main Aug 14, 2023
14 checks passed
@manon-corneille
Copy link
Contributor

Hi guys,

Sorry for my late feedback on this feature, I didn't have the time to test it properly until now.

1. Is it normal that we can't invite users who don't already have an account?
If I do, I get the error message: "Please ask the following users to create an Open Food Facts account first"
This will be the majority of the use cases in my opinion.
Maybe we can send an email to the future user asking him/her to create an account instead?

2. When I invite a user who already has an account, I can see the user in the table, but it doesn't seem to be taken into account in the user profile. Example below: I added charlotte@openfoodfacts.org to the org-kambly-france. However, if I go on Charlotte's profile, the org she's linked to is "org-charlotte" instead of "org-kambly-france"
image
image

@MonalikaPatnaik @stephanegigandet

@alexgarel
Copy link
Member

@manon-corneille we don't support multi-org profiles, and I think it's a bit dangerous to invite someone already in another org (it will leave an org with 0 users).

@manon-corneille
Copy link
Contributor

@alexgarel ok thanks, I understand your point.
As for my first point, let's see how it goes! :-) Maybe it's not so painful from a user's perspective

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Translations We use a non-standard version of GetText, lack language variants support translate.openfoodfacts.org 👥 Users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants