Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix OpenAPI product_extended.yaml #8808

Merged
merged 2 commits into from
Aug 8, 2023
Merged

docs: fix OpenAPI product_extended.yaml #8808

merged 2 commits into from
Aug 8, 2023

Conversation

alexgarel
Copy link
Member

@alexgarel alexgarel commented Aug 7, 2023

What

  • that was blocking rendering with rapidoc.

Part of

  • Open API

that was blocking rendering in rapidoc
@alexgarel alexgarel requested a review from a team as a code owner August 7, 2023 18:06
@github-actions github-actions bot added the 📚 Documentation Documentation issues improve the project for everyone. label Aug 7, 2023
@teolemon
Copy link
Member

teolemon commented Aug 7, 2023

Status: Downloaded newer image for openapitools/openapi-generator-cli:latest
Validating spec (/local/docs/api/ref/api.yml)
Errors:
- attribute is not of type object (./product_extended.yaml)
Warnings:
- Unused model: Product-Metadata
- Unused model: Product-Base
- Unused model: Product-Misc
- Unused model: Product-Tags
- Unused model: Product-Eco-Score
- Unused model: Product-Images
- Unused model: Product-Data-Quality
- Unused model: Product
- Unused model: Product-Ingredients
- Unused model: Product-Nutrition
- Unused model: Product-Knowledge-Panels

Error: Spec has 1 errors.
make: *** [Makefile:347: check_openapi_v2] Error 1
Error: Process completed with exit code 2.

@alexgarel alexgarel enabled auto-merge (squash) August 8, 2023 09:11
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8808 (15e8300) into main (799f250) will not change coverage.
Report is 11 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #8808   +/-   ##
=======================================
  Coverage   48.75%   48.75%           
=======================================
  Files         118      118           
  Lines       22000    22000           
  Branches     4888     4888           
=======================================
  Hits        10726    10726           
  Misses       9968     9968           
  Partials     1306     1306           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alexgarel alexgarel merged commit e38efae into main Aug 8, 2023
15 checks passed
@alexgarel alexgarel deleted the docs-fix-openapi branch August 8, 2023 09:47
@teolemon teolemon added the OpenAPI OpenAPI documentation of Open Food Facts. Still incomplete, and needs help. label Aug 8, 2023
@alexgarel alexgarel restored the docs-fix-openapi branch August 8, 2023 13:38
@alexgarel alexgarel deleted the docs-fix-openapi branch August 8, 2023 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📚 Documentation Documentation issues improve the project for everyone. OpenAPI OpenAPI documentation of Open Food Facts. Still incomplete, and needs help.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants