Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: obsolete support in update_all_products.pl and export status fix on producers platform #8811

Merged
merged 1 commit into from
Aug 8, 2023

Conversation

stephanegigandet
Copy link
Contributor

@stephanegigandet stephanegigandet commented Aug 8, 2023

What

  • When exporting obsolete products from the pro platform to the public platform, we were not updating their export status on the obsolete collection of the pro platform (and instead created them on the non obsolete collection).
  • This PR fixes the export status, and also add support for selecting the obsolete collection in update_all_products.pl, + an option to remove obsolete / non-obsolete products that are not in the appropriate collection.
16019 products updated (pretend: ) - 0 new versions created
9227 removed from wrong collection (obsolete or current)
off@off1:/srv/off-pro/scripts$ ./update_all_products.pl --query owners_tags=org-auchan-apaw --fix-obsolete 

Part of

@stephanegigandet stephanegigandet requested a review from a team as a code owner August 8, 2023 10:24
@github-actions github-actions bot added Data import 🏭 Producers Platform https://wiki.openfoodfacts.org/Platform_for_producers update all products labels Aug 8, 2023
@sonarcloud
Copy link

sonarcloud bot commented Aug 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@codecov-commenter
Copy link

Codecov Report

Merging #8811 (ff36a31) into main (e38efae) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #8811   +/-   ##
=======================================
  Coverage   48.76%   48.76%           
=======================================
  Files         118      118           
  Lines       21998    21998           
  Branches     4889     4889           
=======================================
  Hits        10727    10727           
  Misses       9967     9967           
  Partials     1304     1304           
Files Changed Coverage Δ
lib/ProductOpener/Import.pm 30.67% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@teolemon teolemon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have created a tracker issue for obsolete product issues, and a call for documentation of our policies/behaviours on the wiki

Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stephanegigandet stephanegigandet merged commit ccfb616 into main Aug 8, 2023
16 checks passed
@stephanegigandet stephanegigandet deleted the pro-export-status-2 branch August 8, 2023 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants