Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: Lithuanian labels logos #8874

Merged
merged 7 commits into from
Aug 17, 2023
Merged

taxonomy: Lithuanian labels logos #8874

merged 7 commits into from
Aug 17, 2023

Conversation

DanieliusAsm
Copy link
Contributor

What

Added 2 Lithuanian logos

Screenshot

ekologinis-žemės-ūkis 125x90
lietuvos-metų-gaminys 173x90

@DanieliusAsm DanieliusAsm changed the title taxonomyLt labels logos taxonomy: Lithuanian labels logos Aug 16, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies labels labels Aug 16, 2023
@DanieliusAsm DanieliusAsm marked this pull request as ready for review August 16, 2023 19:06
@DanieliusAsm DanieliusAsm requested a review from a team as a code owner August 16, 2023 19:06
@codecov-commenter
Copy link

codecov-commenter commented Aug 16, 2023

Codecov Report

Merging #8874 (d9ca900) into main (60f350d) will decrease coverage by 3.06%.
Report is 5 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #8874      +/-   ##
==========================================
- Coverage   48.61%   45.55%   -3.06%     
==========================================
  Files         118       64      -54     
  Lines       22069    19511    -2558     
  Branches     4903     4737     -166     
==========================================
- Hits        10728     8889    -1839     
+ Misses      10038     9445     -593     
+ Partials     1303     1177     -126     

see 81 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@benbenben2
Copy link
Collaborator

Looks good to me.
Just a question: did you try it locally? Was it working fine? Can you see the page of the label (like https://lt.openfoodfacts.org/label/lietuvos-metų-gaminys) with the logo of the label?

I am a bit concerned about the Lithuanian characters, if it would work or not

@DanieliusAsm
Copy link
Contributor Author

DanieliusAsm commented Aug 17, 2023

@benbenben2 I dont have a setup to run the project. Since I have internet blocker with a delay of 3 days, that means in order to make changes and allow certain websites/programs I have to wait 3 days. I will try and get the local setup working. (eventually)

I will rename them and take out the special characters from files

@sonarcloud
Copy link

sonarcloud bot commented Aug 17, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@benbenben2
Copy link
Collaborator

benbenben2 commented Aug 17, 2023

@benbenben2 I dont have a setup to run the project. Since I have internet blocker with a delay of 3 days, that means in order to make changes and allow certain websites/programs I have to wait 3 days. I will try and get the local setup working. (eventually)

I will rename them and take out the special characters from files

It was approved by Stephane. I assume that it will be fine. I will squash and merge.

@benbenben2 benbenben2 merged commit d1c9065 into openfoodfacts:main Aug 17, 2023
13 checks passed
@DanieliusAsm DanieliusAsm deleted the lt-labels-logos branch August 24, 2023 17:38
@teolemon teolemon added the 🇱🇹 Lithuania https://lt.openfoodfacts.org/ label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
labels 🇱🇹 Lithuania https://lt.openfoodfacts.org/ 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants