Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

taxonomy: Update polish taxonomy #8898

Merged
merged 2 commits into from
Aug 23, 2023
Merged

taxonomy: Update polish taxonomy #8898

merged 2 commits into from
Aug 23, 2023

Conversation

ArturLange
Copy link
Contributor

What

I added and fixed some missing/wrong Polish translations in taxonomies

@ArturLange ArturLange requested a review from a team as a code owner August 22, 2023 17:37
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🥗 Ingredients 🥜 Allergens 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Aug 22, 2023
@ArturLange ArturLange force-pushed the pl-taxonomy-update branch 2 times, most recently from 1ec00be to 50f0024 Compare August 22, 2023 18:25
@codecov-commenter
Copy link

Codecov Report

Merging #8898 (1ec00be) into main (a801922) will decrease coverage by 15.67%.
Report is 2 commits behind head on main.
The diff coverage is n/a.

❗ Current head 1ec00be differs from pull request most recent head 50f0024. Consider uploading reports for the commit 50f0024 to get more accurate results

@@             Coverage Diff             @@
##             main    #8898       +/-   ##
===========================================
- Coverage   45.54%   29.87%   -15.67%     
===========================================
  Files          64       55        -9     
  Lines       19519    16805     -2714     
  Branches     4738     4030      -708     
===========================================
- Hits         8889     5021     -3868     
- Misses       9454    11018     +1564     
+ Partials     1176      766      -410
Files Changed Coverage Δ
lib/ProductOpener/Ingredients.pm 73.55% <ø> (-17.85%) ⬇️

... and 39 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

benbenben2
benbenben2 approved these changes Aug 23, 2023
View reviewed changes
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done.
Looks good to me.

@benbenben2 benbenben2 merged commit d3304c1 into openfoodfacts:main Aug 23, 2023
13 checks passed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Aug 23, 2023
Merged
@ArturLange ArturLange deleted the pl-taxonomy-update branch August 28, 2023 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benbenben2 benbenben2 benbenben2 approved these changes

Assignees

@ArturLange ArturLange

Labels
🥜 Allergens categories 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis 🥗 Ingredients 📦 Packaging https://wiki.openfoodfacts.org/Category:Recycling 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ArturLange @codecov-commenter @benbenben2