Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: week45 improvements #9310

Merged
merged 16 commits into from
Nov 20, 2023
Merged

chore: week45 improvements #9310

merged 16 commits into from
Nov 20, 2023

Conversation

aleene
Copy link
Contributor

@aleene aleene commented Nov 13, 2023

What

Improvements to the taxonomy

@aleene aleene self-assigned this Nov 13, 2023
@aleene aleene marked this pull request as draft November 13, 2023 17:50
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Nov 13, 2023
@aleene aleene removed the categories label Nov 13, 2023
Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aleene!

taxonomies/nutrients.txt Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0c9912d) 48.14% compared to head (517dbd9) 48.14%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9310   +/-   ##
=======================================
  Coverage   48.14%   48.14%           
=======================================
  Files          65       65           
  Lines       20341    20341           
  Branches     4931     4931           
=======================================
  Hits         9794     9794           
  Misses       9296     9296           
  Partials     1251     1251           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleene aleene marked this pull request as ready for review November 20, 2023 12:50
Copy link

sonarcloud bot commented Nov 20, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@alexgarel alexgarel merged commit 5cde2c4 into main Nov 20, 2023
13 checks passed
@alexgarel alexgarel deleted the aleene-week45 branch November 20, 2023 14:58
alexgarel pushed a commit that referenced this pull request Nov 21, 2023
* Gevulde croissants

* Croissants (gevuld)

* glucoligosaccharide

* Pastasauzen met vlees

* Update categories.txt

* en:Kosher LBD

* Vitamine B3/PP (Niacin)

* Borlotti bonen

* Gedroogde kikkererwten

* suco de uva

* suco de uva

* Update taxonomies/nutrients.txt

Co-authored-by: Charles Nepote <charles@nepote.org>

---------

Co-authored-by: Charles Nepote <charles@nepote.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories ingredients labels 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants