Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dq error for product quantity above 30kg #9316

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

benbenben2
Copy link
Collaborator

What

add dq error for product quantity above 30kg
added test for it + for others quantity warning (above 10kg below 1g and in mg)

Screenshot_20231114_165651

Related issue(s) and discussion

@benbenben2 benbenben2 requested a review from a team as a code owner November 14, 2023 16:00
@benbenben2 benbenben2 self-assigned this Nov 14, 2023
@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧪 tests labels Nov 14, 2023
Copy link

sonarcloud bot commented Nov 14, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Copy link
Member

@CharlesNepote CharlesNepote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks a lot!

Copy link
Contributor

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanegigandet stephanegigandet merged commit b7fe2b2 into main Nov 15, 2023
13 checks passed
@stephanegigandet stephanegigandet deleted the feat_error_quantity_above_30kg branch November 15, 2023 08:39
alexgarel pushed a commit that referenced this pull request Nov 21, 2023
* add dq error for product quantity above 30kg

* make lint

* fix missing parent error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧽 Data quality https://wiki.openfoodfacts.org/Quality 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies 🧪 tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data quality error for quantity
3 participants