Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

taxonomy: large update on processed meats #9828

Merged
merged 7 commits into from
Feb 28, 2024
Merged

Conversation

OpenChris
Copy link
Contributor

Large update on "Charcuteries" - processed meats

@github-actions github-actions bot added 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies categories labels Feb 25, 2024
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @OpenChris!

I made few suggestions, mostly about starting with "en:" I would be super if you could apply them.

taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Outdated Show resolved Hide resolved
taxonomies/categories.txt Show resolved Hide resolved
Copy link
Collaborator

@benbenben2 benbenben2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OpenChris
I will approve but before to merge please consider the following changes if you agree (I don't know Spanish at all so I will let you decide if it is better or not):

en:loins
es:lomo

<en:Pork
<en:loins
en:Pork loin
fr:Longe de porc
es:Lomo de cerdo
(etc.)

<en:Pork loin
en:Cured pork loin

<en:Pork loin
en:stuffed pork loin

<en:stuffed pork loin
en:lomo embuchado
es:lomo embuchado

<en:Pork loin
en:cured pork loin

Because it seems to me that lomo is loin. Also, lomo embuchado may be same in English: https://www.wikidata.org/wiki/Q1868800

@OpenChris
Copy link
Contributor Author

Thanks @benbenben2 - Wikidata doesn't place pork loin as a child of the more general 'loin' category.
I would rather follow this approach and avoid creating a general loin category. Also loin would include all animals but also fish for example so it is a very large category - unless you also create meat-loin and fish-loin categories.
I will place lomo embuchado inside a parent 'cured pork loin', with the english equivalent, as you suggest.
Stuffed pork loin is a recipe (very delicious) with cooked "filet mignon", not with the full pork loin. And it is not from cured loin but fresh one.

@OpenChris
Copy link
Contributor Author

As for the word 'Lomo' without any precision, it is really always associated with the cured version of the loin in shops. I suggest we keep it as a tag for Lomo embuchado since it is actually what you buy by default. I'm fine if s.o. has a better rule of course. I'm not an expert in spanish ;-)

Copy link

sonarcloud bot commented Feb 28, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@OpenChris OpenChris merged commit 49e9ae3 into main Feb 28, 2024
12 checks passed
@OpenChris OpenChris deleted the openchris-taxonomies branch February 28, 2024 09:08
@alexgarel
Copy link
Member

@OpenChris thanks for your work 🎉

@benbenben2 thanks for validating :-)

john-gom pushed a commit that referenced this pull request May 24, 2024
* taxonomy: large update on processed meats

* fix: parent typo

* taxonomy: fixes from @benbenben2 comments

mostly add en: tags

* taxonomy: final precisions on Lomo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
categories 🧬 Taxonomies https://wiki.openfoodfacts.org/Global_taxonomies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants