fix: update pymongo #1267
Merged
fix: update pymongo #1267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphael0202
force-pushed
the
update-pymongo
branch
from
aba3ec3
to
4811715
Compare
raphael0202
force-pushed
the
update-pymongo
branch
from
4811715
to
d5c5a79
Compare
|
@raphael0202 Would it make sense to reduce maxPoolSize (defaults to 100, but applies to each client, I don't know how many you can spawn?) https://pymongo.readthedocs.io/en/stable/api/pymongo/mongo_client.html |
Codecov Report
@@ Coverage Diff @@
## main #1267 +/- ##
=======================================
Coverage 56.39% 56.39%
=======================================
Files 77 77
Lines 7440 7440
=======================================
Hits 4196 4196
Misses 3244 3244
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@stephanegigandet From what I understand, multiple connections should only happen in a multi-threaded setting (https://pymongo.readthedocs.io/en/stable/faq.html#how-does-connection-pooling-work-in-pymongo), which never happens for us: we instanciate the MongoClient after thread fork in all robotoff services. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After incident of the weekend: openfoodfacts/openfoodfacts-infrastructure#265