Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging Flashtext extension #602

Merged
merged 19 commits into from
Feb 9, 2022
Merged

Packaging Flashtext extension #602

merged 19 commits into from
Feb 9, 2022

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Feb 4, 2022

What

  • Brute-force extend the number of French recycling instructions we can extract based on CITEO guidelines

Part of

@teolemon teolemon marked this pull request as draft February 4, 2022 11:04
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
data/ocr/packaging.txt Outdated Show resolved Hide resolved
@teolemon teolemon marked this pull request as ready for review February 7, 2022 15:17
@teolemon teolemon requested a review from a team February 7, 2022 15:17
@teolemon
Copy link
Member Author

teolemon commented Feb 9, 2022

=========================== short test summary info ============================
FAILED tests/unit/prediction/ocr/test_packaging.py::test_packaging_format - A...
FAILED tests/unit/prediction/ocr/test_packaging.py::test_find_packaging[Tetrapack-value_tags0]
FAILED tests/unit/prediction/ocr/test_packaging.py::test_find_packaging[tetrapack-value_tags1]
FAILED tests/unit/prediction/ocr/test_packaging.py::test_find_packaging[Packaging: bo\xeete carton,...-value_tags2]
FAILED tests/unit/prediction/ocr/test_packaging.py::test_find_packaging[Ingr\xe9dients: 100% tomate-value_tags3]
FAILED tests/unit/prediction/ocr/test_packaging.py::test_find_packaging[emballage: bouteille verre et son bouchon...-value_tags5]
============ 6 failed, 237 passed, 15 warnings in 118.98s (0:01:58) ============

data/ocr/packaging.txt Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 9, 2022

Codecov Report

Merging #602 (05793f9) into master (1e63ca2) will increase coverage by 2.28%.
The diff coverage is 77.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
+ Coverage   44.73%   47.02%   +2.28%     
==========================================
  Files          96       96              
  Lines        6981     7067      +86     
==========================================
+ Hits         3123     3323     +200     
+ Misses       3858     3744     -114     
Impacted Files Coverage Δ
robotoff/off.py 25.57% <ø> (+5.02%) ⬆️
robotoff/metrics.py 23.61% <10.00%> (-2.20%) ⬇️
robotoff/scheduler/__init__.py 40.00% <33.33%> (+9.71%) ⬆️
robotoff/app/api.py 37.27% <77.77%> (+8.04%) ⬆️
robotoff/app/core.py 82.60% <83.72%> (+15.94%) ⬆️
robotoff/insights/importer.py 56.39% <87.50%> (+0.38%) ⬆️
robotoff/elasticsearch/export.py 97.22% <100.00%> (ø)
robotoff/insights/annotate.py 41.73% <100.00%> (+12.76%) ⬆️
robotoff/insights/dataclass.py 100.00% <100.00%> (ø)
robotoff/insights/question.py 62.73% <100.00%> (+1.09%) ⬆️
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93d30da...05793f9. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Feb 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@mithridatea mithridatea merged commit 0cae35e into master Feb 9, 2022
@mithridatea mithridatea deleted the packaging-flashtext branch February 9, 2022 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants