After taking a photo and cropping, image shown is the previous one

[alexgarel]

What

If I use the app to take a photo, and then use it again to take another photo, after taking the photo and validating, the image is not the new one taken but the old one.
Though the right photo as been sent to the app.

Steps to reproduce the behavior

See second-photo-bug.pdf

Expected behavior

The photo shown for confirmation and the thumbnail should have been the ingredients photo.

Why

It's important because this is really misleading to users ! And photos are our raw fuel for the database :-)

Smartphone model

• Device: Huawei Y7 / Samsung S9 (same bug)
• OS: Android 8.0.0
• App Version 0.0.2+211 (dev mode)

Tracked in

• Product addition (tracker) #1379

[monsieurtanuki]

Hi @alexgarel!

Unfortunately I cannot test that, and I guess it's not easy to test either if each time you need to find a new product. We probably need to find a smart way to test it again and again.

What I can say is that on image_crop_page.dart (cf. your step 4) we always use the same final String filePath = '$tempPath/upload_img_file.tmp';, which is probably not a good idea. My hunch is that the file image display has a hidden cache facility and therefore may not refresh the display even when the file is different (and successfully uploaded).

Other suspicious code - after ConfirmAndUploadPicture we get the final photo but it's not the one we use to populate the list:

if (finalPhoto != null) { // finalPhoto is the one the user has eventually chosen
  _uploadedImages[imageType] = _uploadedImages[imageType] ?? <File>[];
  _uploadedImages[imageType]!.add(initialPhoto); // ... but we put the initialPhoto instead
  setState(() {});
}

[teolemon]

@monsieurtanuki : books :-)

[M123-dev]

Looks like both should be relatively easy to solve

[teolemon]

Thanks for the detailed filing @alexgarel

[cli1005]

Issue can not be reproduced:

[teolemon]

cc @alexgarel

[M123-dev]

Fixed by the cropping library switch