Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The onboarding title does not honor dark mode #1218

Closed
Tracked by #561
, #684
...
teolemon opened this issue Mar 16, 2022 · 6 comments
Closed
Tracked by #561
, #684
...

The onboarding title does not honor dark mode #1218

teolemon opened this issue Mar 16, 2022 · 6 comments
Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…

Comments

@teolemon
Copy link
Member

What

  • The onboarding title does not honor dark mode
  • The Next Button is not contrasted enough

Part of

Screenshot/Mockup/Before-After

image
@teolemon teolemon added 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score… darkmode Ensuring we look good in the dark good first issue Good for newcomers labels Mar 16, 2022
@monsieurtanuki
Copy link
Contributor

@teolemon As mentioned in another issue, I don't think dark mode can be activated before the onboarding (in smoothie at least). Therefore onboarding and dark mode are not supposed to happen IRW.

@GowthamGoush
Copy link
Contributor

If the user prefers to open the app under the forced dark mode, should we consider adding dark mode support here?

This was referenced Mar 18, 2022
Open
Closed
@bhattabhi013
Copy link
Contributor

bhattabhi013 commented Mar 26, 2022 •
edited

This issue is not present anymore, I think we should close this issue.
image

@M123-dev
Copy link
Member

The problem still occurs to me

@M123-dev
Copy link
Member

But yes @GowthamGoush

@teolemon
Copy link
Member Author

This one is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
darkmode Ensuring we look good in the dark good first issue Good for newcomers 🤗 Onboarding We need to onboard users on how the app works, but also on content like Nutri-Score, Eco-Score…
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
5 participants
@teolemon @monsieurtanuki @M123-dev @bhattabhi013 @GowthamGoush