Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The cross needed to remove one product from the product carousel is missing #1295

Closed
teolemon opened this issue Mar 22, 2022 · 1 comment · Fixed by #1662
Closed

The cross needed to remove one product from the product carousel is missing #1295

teolemon opened this issue Mar 22, 2022 · 1 comment · Fixed by #1662
Labels
🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. P3 product scan carousel
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Mar 22, 2022 •
edited

What

  • The cross needed to remove one product from the product carousel is missing
  • We should add a one time warning that this will only remove from the comparison, and not from history

Why

  • Allows to finetune custom comparisons

Part of

Screenshot

image
@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@teolemon teolemon added the 🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. label Mar 31, 2022
@teolemon teolemon added the P3 label Apr 11, 2022
@teolemon teolemon mentioned this issue Apr 18, 2022
Closed
1 task
@M123-dev M123-dev mentioned this issue Apr 25, 2022
Closed
@M123-dev
Copy link
Member

Assigned to @bhattabhi013

@bhattabhi013 bhattabhi013 mentioned this issue Apr 26, 2022
Merged
@teolemon teolemon linked a pull request Apr 27, 2022 that will close this issue
feat: Remove individual product from the scan carousel #1662
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 Mockups available Some mockups are available for this issue. Please check everything is ok before starting coding. P3 product scan carousel
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

feat: Remove individual product from the scan carousel
2 participants
@teolemon @M123-dev