It seems that onboarding is not detecting the country anymore

[teolemon]

What

• It seems that onboarding is not detecting the country anymore

Steps to reproduce the behavior

1. Go to Dev Mode
2. Click on 'Restart onboarding'
3. See US selected by default

Expected behavior

The app uses the phones lang_country code or any kind of local wizardry to infer country

Part of

• 🐣 The app should onboard users (Tracker) #561

Screenshot/Mockup/Before-After

Smartphone model

• Android 12L Pixel 6 and others

[VaiTon]

Is your phone in English?

smooth-app/packages/smooth_app/lib/pages/onboarding/country_selector.dart

Line 36 in 4495613

final String locale = Localizations.localeOf(context).languageCode;

If that's so it is right because the code is taking the en and showing countries with en as primary language.

[teolemon]

It seems there are better ways
https://stackoverflow.com/questions/50923906/how-to-get-timezone-language-and-county-id-in-flutter-by-the-location-of-device
https://stackoverflow.com/questions/59408567/how-to-get-current-country-code-in-flutter

[VaiTon]

What behavior do we want for this?

• It gets the actual used language and try to guess which country it is from;
• It gets the actual locale from the device;
• It access the user's location to get the actual country?

[g123k]

With the upcoming version of Android (13), users can opt for a different language per application.
The current implementation will reach its limits with that change.

Maybe we should use a combination of several data:

• Current timezone
• Location of the "external" IP
• User language

Let's imagine with all these inputs, we still have several choices, we could show them at the top of the list of choices

[monsieurtanuki]

Perhaps it would be easier and more intuitive to implement a search field as already mentioned in #1200 by @bhattabhi013, or find another country picker (like https://pub.dev/packages/country_picker ?)
That would look a bit like the iOS settings:

Btw on my iOS emulator the country is correctly detected (from the emulator settings).

[VaiTon]

Maybe we should use a combination of several data:

* Current timezone
* Location of the "external" IP
* User language

Using the second one would not be that privacy-friendly of us :(

[teolemon]

• 2016 issue: Provide an API to give languages and countries supported, given an IP openfoodfacts-server#507

[monsieurtanuki]

@teolemon I assumed that the languages and countries supported are the ones found in off-dart's OpenFoodFactsLanguage and OpenFoodFactsCountry.

[M123-dev]

Still a thing @teolemon ?

[monsieurtanuki]

https://pub.dev/packages/devicelocale may help (never tried)

[M123-dev]

Should be fixed