Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the name of the knowledge panel visible (per mocks) #1414

Closed
1 task
teolemon opened this issue Mar 30, 2022 · 5 comments · Fixed by #1442
Closed
1 task

Make the name of the knowledge panel visible (per mocks) #1414

teolemon opened this issue Mar 30, 2022 · 5 comments · Fixed by #1442
Assignees
@AshAman999
Labels
📖 Knowledge panels P2 P3
Milestone
V1

Comments

@teolemon
Copy link
Member

teolemon commented Mar 30, 2022 •
edited

What

  • Make the name of the knowledge panel visible (per mocks) using the available field in the API

image
image

Part of
@AshAman999
Copy link
Member

Will do that,
Plz assign me this issue

@teolemon
Copy link
Member Author

Done @AshAman999
It's probably already mapped in openfoodfacts-dart, otherwise you may have to do a PR there.

@teolemon teolemon added this to the V 1 milestone Mar 31, 2022
@AshAman999
Copy link
Member

Done @AshAman999 It's probably already mapped in openfoodfacts-dart, otherwise you may have to do a PR there.

I think that's not needed, got it working will raise a pr soon :)

@AshAman999
Copy link
Member

One question, how do I make this first alphabet capitalized? I guess there is no direct method so should I
create a utility method for the same or one is already there? 😕

Screenshot_1648827277

@M123-dev
Copy link
Member

M123-dev commented Apr 1, 2022

I don't know one, at least not in our codebase. Feel free to create one 👍🏼

@AshAman999 AshAman999 mentioned this issue Apr 1, 2022
Merged
@teolemon teolemon linked a pull request Apr 1, 2022 that will close this issue
fix: knowledge panel name made visible #1442
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AshAman999 AshAman999

Labels
📖 Knowledge panels P2 P3
Projects
🤳🥫 The Open Food Facts mobile app (Android & iOS)
Archived in project
Milestone
V1
Development

Successfully merging a pull request may close this issue.

fix: knowledge panel name made visible AshAman999/smooth-app
3 participants
@teolemon @M123-dev @AshAman999