Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add image selection from server in the Photo Manager (the expanded view accessible from the carousel) #2424

Closed
2 tasks
Tracked by #766
teolemon opened this issue Jun 29, 2022 · 2 comments · Fixed by #3641
Closed
2 tasks
Tracked by #766

Comments

@teolemon
Copy link
Member

teolemon commented Jun 29, 2022

What

  • Photos already on the server, and selected for a purpose (eg ingredients) contain valuable info (like a nutrition table)
  • Create a view listing all the images available for a product server-side
  • Make this view reusable in the photo picker

Part of

@teolemon teolemon added image carousel https://github.com/openfoodfacts/smooth-app/issues/966 images image upload and removed image carousel https://github.com/openfoodfacts/smooth-app/issues/966 labels Jun 29, 2022
@teolemon teolemon changed the title Create a photo gallery of server-side available photos the user can select an image from Add image selection from server in the expanded view accessible from the carousel Jun 29, 2022
@teolemon teolemon changed the title Add image selection from server in the expanded view accessible from the carousel Add image selection from server in the Photo Manager (the expanded view accessible from the carousel) Jul 3, 2022
@teolemon teolemon added the P2 label Aug 20, 2022
@monsieurtanuki monsieurtanuki self-assigned this Jan 25, 2023
@monsieurtanuki
Copy link
Contributor

Waiting for openfoodfacts/openfoodfacts-dart#689 to be reviewed.

This is what it will look like:
Capture d’écran 2023-01-26 à 09 40 11

A bit similar to what @VaiTon implemented in #2724, but now we make a strict distinction between the 4 main images (in one page) and the bulk of uploaded images (in a specific page).

@monsieurtanuki
Copy link
Contributor

I must say that it works very well and that of course the server answers quickly - here we don't upload anything, we just crop an existing image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging a pull request may close this issue.

2 participants