Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get the Eco-Score into smoothie #25

Closed
4 tasks
teolemon opened this issue Nov 21, 2020 · 3 comments
Closed
4 tasks

Get the Eco-Score into smoothie #25

teolemon opened this issue Nov 21, 2020 · 3 comments

Comments

@teolemon
Copy link
Member

Implementation

  • Clone the system that displays Nutri-Score on the scan card
  • Change the server request url to ecoscore (server-side issue: Add an API field to display the Eco-Score openfoodfacts-server#4262)
  • If (and only if) the server sends back a proper value (a, b, c, d or e), hide the classic CO2 value and display the new score
    https://world.openfoodfacts.org/api/v0/product/3414280980209.json?fields=ecoscore_grade (Here it shows null)
  • Please use the Eco-Score visuals placeholders until we have the final visuals.

Placeholders with the right size

https://static.openfoodfacts.org/images/icons/ecoscore-a.svg
https://static.openfoodfacts.org/images/icons/ecoscore-b.svg
https://static.openfoodfacts.org/images/icons/ecoscore-c.svg
https://static.openfoodfacts.org/images/icons/ecoscore-d.svg
https://static.openfoodfacts.org/images/icons/ecoscore-e.svg
https://static.openfoodfacts.org/images/icons/ecoscore-unknown.svg

https://static.openfoodfacts.org/images/icons/ecoscore-a.png
https://static.openfoodfacts.org/images/icons/ecoscore-b.png
https://static.openfoodfacts.org/images/icons/ecoscore-c.png
https://static.openfoodfacts.org/images/icons/ecoscore-d.png
https://static.openfoodfacts.org/images/icons/ecoscore-e.png
https://static.openfoodfacts.org/images/icons/ecoscore-unknown.png

@stephanegigandet
Copy link
Contributor

The Eco-score will be shown in Smoothie's scan cards as an attribute: #32 The attributes will replace the current display with the Nutriscore, NOVA and CO2,, and add the Eco-score.

We should also display the Eco-score details in an environment tab in the full product page.

@monsieurtanuki
Copy link
Contributor

The Eco-score will be shown in Smoothie's scan cards as an attribute: #32

@stephanegigandet Then this issue doesn't make sense anymore, does it?

@stephanegigandet
Copy link
Contributor

Issue replaced with #32 and #37

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants