Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #2575 - fixed brightness check for app icon #2579

Merged
merged 1 commit into from Jul 11, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • user_preferences_faq.dart: fixed brightness check for app icon

What

  • Fixed brightness check for app icon

Screenshot

light dark
Capture d’écran 2022-07-11 à 11 36 06 Capture d’écran 2022-07-11 à 11 36 34

Fixes bug(s)

Impacted file:
* `user_preferences_faq.dart`: fixed brightness check for app icon
@codecov-commenter
Copy link

Codecov Report

Merging #2579 (8e1ec44) into develop (2ea0da3) will decrease coverage by 1.31%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2579      +/-   ##
==========================================
- Coverage     8.86%   7.55%   -1.32%     
==========================================
  Files          161     210      +49     
  Lines         6623   10103    +3480     
==========================================
+ Hits           587     763     +176     
- Misses        6036    9340    +3304     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 60.00% <0.00%> (-22.98%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.29% <0.00%> (-18.92%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 24.65% <0.00%> (-6.78%) ⬇️
packages/smooth_app/lib/main.dart 14.16% <0.00%> (-3.73%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
...smooth_app/lib/pages/product/new_product_page.dart 0.00% <0.00%> (-0.88%) ⬇️
... and 219 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2b60cb5...8e1ec44. Read the comment docs.

@teolemon
Copy link
Member

thank you

@teolemon teolemon merged commit 8446b30 into openfoodfacts:develop Jul 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Smoothie is composed of one sliced orange
4 participants