fix: The virtual keyboard is sometimes visible after clicking on the Search field on the homepage #2712
+62
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
+ add some nice ripples
AshAman999
reviewed
Aug 2, 2022
| ), | ||
| style: const TextStyle(fontSize: 18.0), | ||
| hintText: localizations.search, | ||
| suffixIcon: widget.showClearButton ? _buildClearButton() : null, |
There was a problem hiding this comment.
Could we have used this variable instead of creating readOnly here?
There was a problem hiding this comment.
That's another way to design this, true.
But my idea was to limit the changes on the external API
There was a problem hiding this comment.
Okay then it's fine, can be merged!
AshAman999
approved these changes
Aug 2, 2022
|
thanks @g123k |
Nice idea indeed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The homepage card displays a
TextFieldthat does nothing. Once it has the focus, it opens a screen.On some devices, the event to open the keyboard has the time to be consumed, hence the issue.
To prevent this behavior, I have created a fake button, with also some lovely ripples 😋
https://user-images.githubusercontent.com/246838/182380411-20e1f8af-322f-4acc-a72d-b5b57c4159a9.mp4
Will fix #2531