feat: #1343 - "world" queries and faster cached result display #2718
+207
−408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…isplay Deleted file: * `group_query_filter_view.dart`: old code never used and never changed Impacted files: * `app_en.arb`: added 2 labels for "world results" * `app_fr.arb`: added 2 labels for "world results" * `category_product_query.dart`: implemented world query * `keywords_product_query.dart`: implemented world query * `paged_product_query.dart`: introduced word query parameter and methods * `paged_search_product_query.dart`: implemented world query * `paged_to_be_completed_product_query.dart`: implemented world query * `product_list_supplier.dart`: refactored * `product_model.dart`: loosely related safer "notifyListeners" method * `product_query.dart`: now storing here the country, which makes "world" queries possible * `product_query_model.dart`: removed all the "category filter" code; better management of the "what if the refresh download fails?" case * `product_query_page.dart`: added "world" queries; removed the "category filter" code; now displays a `MaterialBanner` (more flexibility than a `SnackBar`) * `smooth_theme.dart`: added a banner theme for `MaterialBanner`
monsieurtanuki
commented
Aug 3, 2022
VaiTon
approved these changes
Aug 3, 2022
|
Thank you @VaiTon for your review! |
This was referenced Aug 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deleted file:
group_query_filter_view.dart: old code never used and never changedImpacted files:
app_en.arb: added 2 labels for "world results"app_fr.arb: added 2 labels for "world results"category_product_query.dart: implemented world querykeywords_product_query.dart: implemented world querypaged_product_query.dart: introduced word query parameter and methodspaged_search_product_query.dart: implemented world querypaged_to_be_completed_product_query.dart: implemented world queryproduct_list_supplier.dart: refactoredproduct_model.dart: loosely related safer "notifyListeners" methodproduct_query.dart: now storing here the country, which makes "world" queries possibleproduct_query_model.dart: removed all the "category filter" code; better management of the "what if the refresh download fails?" caseproduct_query_page.dart: added "world" queries; removed the "category filter" code; now displays aMaterialBanner(more flexibility than aSnackBar)smooth_theme.dart: added a banner theme forMaterialBannerWhat
Screenshot
Fixes bug(s)