Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Edit product page UI improvements #2754

Merged
merged 3 commits into from Aug 16, 2022

Conversation

g123k
Copy link
Collaborator

@g123k g123k commented Aug 8, 2022

  • On scroll, the barcode will be visible in the AppBar
  • The copy barcode is now in the AppBar
  • The photo icon is filled, like the other icons
  • The title on each item is in bold
  • Ripples on each card is now OK
  • Scrollbar for the list
untitled.mp4

@g123k g123k requested a review from a team as a code owner August 8, 2022 14:40
@g123k g123k self-assigned this Aug 8, 2022
@g123k g123k mentioned this pull request Aug 8, 2022
@g123k g123k linked an issue Aug 8, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2022

Codecov Report

Merging #2754 (46a03d3) into develop (2ea0da3) will decrease coverage by 1.72%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           develop   #2754      +/-   ##
==========================================
- Coverage     8.86%   7.13%   -1.73%     
==========================================
  Files          161     218      +57     
  Lines         6623   10604    +3981     
==========================================
+ Hits           587     757     +170     
- Misses        6036    9847    +3811     
Impacted Files Coverage Δ
...kages/smooth_app/lib/widgets/attribute_button.dart 0.00% <0.00%> (-92.00%) ⬇️
...s/smooth_app/lib/data_models/user_preferences.dart 8.73% <0.00%> (-23.57%) ⬇️
packages/smooth_app/lib/themes/smooth_theme.dart 62.26% <0.00%> (-20.72%) ⬇️
...p/lib/generic_lib/dialogs/smooth_alert_dialog.dart 15.11% <0.00%> (-19.10%) ⬇️
...mooth_app/lib/data_models/product_preferences.dart 21.68% <0.00%> (-9.75%) ⬇️
packages/smooth_app/lib/main.dart 14.65% <0.00%> (-3.24%) ⬇️
.../smooth_app/lib/pages/onboarding/welcome_page.dart 0.00% <0.00%> (-3.13%) ⬇️
.../smooth_app/lib/pages/onboarding/scan_example.dart 0.00% <0.00%> (-2.28%) ⬇️
...ackages/smooth_app/lib/pages/scan/scan_header.dart 2.50% <0.00%> (-2.27%) ⬇️
...p/lib/pages/onboarding/consent_analytics_page.dart 0.00% <0.00%> (-1.57%) ⬇️
... and 237 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

maxLines: _barcodeVisibleInAppbar ? 1 : 2,
),
if (_product.barcode?.isNotEmpty == true)
Visibility(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about using AnimatedSwitcher instead of the Visibility widget? It should make the transition animated.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since the title can initially be on two lines, the rendering is not well appealed.
A custom one is required here. We should maybe implement it later?

@teolemon
Copy link
Member

@g123k needs rebase before merging

@g123k
Copy link
Collaborator Author

g123k commented Aug 16, 2022

Should be OK now 👌

@teolemon teolemon merged commit 8ed337b into openfoodfacts:develop Aug 16, 2022
@g123k g123k deleted the edit_product_page branch September 2, 2022 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

Incorrect Ripple shape
4 participants