fix: improve ios launch screen on notch devices

[simonbengtsson]

What

Fixes position of the launch screen logo on notch devices.

Screenshot

[codecov-commenter]

Codecov Report

Merging #2810 (eda84c3) into develop (85f491b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           develop   #2810   +/-   ##
=======================================
  Coverage     7.05%   7.05%           
=======================================
  Files          219     219           
  Lines        10864   10864           
=======================================
  Hits           766     766           
  Misses       10098   10098           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[teolemon]

Nice. Fyi, it's also happening on non notch devices

[monsieurtanuki]

Quickly said: I'm not saying your fix doesn't fix the issue, but we're using a splash screen generator. Whatever you fix downstream would be overridden at the next splash screen generation (e.g. new logo). You have to fix parameters given to the splash screen generator instead (cf. pubspec.yaml).

…

________________________________ De : Simon Bengtsson ***@***.***> Envoyé : vendredi 19 août 2022 22:19 À : openfoodfacts/smooth-app ***@***.***> Cc : monsieurtanuki ***@***.***>; Review requested ***@***.***> Objet : [openfoodfacts/smooth-app] fix: improve ios launch screen on notch devices (PR #2810) What Fixes position of the launch screen logo on notch devices. Screenshot [Screen Shot 2022-08-19 at 22 18 13]<https://user-images.githubusercontent.com/3586691/185700531-1291878d-057b-4f2b-8424-8a35d6e41e9d.png>

________________________________ You can view, comment on, or merge this pull request online at: #2810 Commit Summary * 1f0aa93<1f0aa93> fix: improve ios launch screen on notch devices File Changes (1 file<https://github.com/openfoodfacts/smooth-app/pull/2810/files>) * M packages/smooth_app/ios/Runner/Base.lproj/LaunchScreen.storyboard<https://github.com/openfoodfacts/smooth-app/pull/2810/files#diff-d9dc5f85f26c99e61aaefac4bc1ad308cf2ad1cbee717b407e8c65b98678768d> (5) Patch Links: * https://github.com/openfoodfacts/smooth-app/pull/2810.patch * https://github.com/openfoodfacts/smooth-app/pull/2810.diff — Reply to this email directly, view it on GitHub<#2810>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ACYKI34IKKDR2M3X4MMKNO3VZ7T3VANCNFSM57B3K37Q>. You are receiving this because your review was requested.Message ID: ***@***.***>

[simonbengtsson]

Oh! Didn't see that. Tried running the flutter_native_splash:create command now, but it resulted in 50+ file changes and a different launch screen on iOS than in app today (see below). Should we add an issue about fixing the splash screen generation and in the meantime merge this PR?

Launch screen after flutter_native_splash:create

[M123-dev]

Thats right @monsieurtanuki but I'm not sure if we are currently using the files of the generator, @g123k did some changes to use svgs instead of pngs which was not supported by the plugin but this could also just have affected the app icon. @g123k what do you say?

[M123-dev]

Fixes: #2787

[g123k]

Thats right @monsieurtanuki but I'm not sure if we are currently using the files of the generator, @g123k did some changes to use svgs instead of pngs which was not supported by the plugin but this could also just have affected the app icon. @g123k what do you say?

Yes indeed, I did it manually because the plugin generated broken things.
We should remove it and do everything manually.

[monsieurtanuki]

Honestly I would prefer us to use flutter_native_splash, which is a "Flutter Favorite" with 100% popularity and only 9 open issues. I don't think we can be much smarter than them, and that's not where we're supposed to be good at anyway.
And if the problem is just how to generate png files from svg files, I'm sure we can manage that.

That said, if there's a consensus about getting rid of that package, that's not my project so why not. But if you guys decide remove flutter_native_splash, do remove it.

Btw that is the answer to the current PR: jonbhanson/flutter_native_splash#325

[g123k]

Honestly I would prefer us to use flutter_native_splash, which is a "Flutter Favorite" with 100% popularity and only 9 open issues. I don't think we can be much smarter than them, and that's not where we're supposed to be good at anyway. And if the problem is just how to generate png files from svg files, I'm sure we can manage that.

That said, if there's a consensus about getting rid of that package, that's not my project so why not. But if you guys decide remove flutter_native_splash, do remove it.

Btw that is the answer to the current PR: jonbhanson/flutter_native_splash#325

I’m still convinced to to do it manually since our custom Android implementation supports dark mode and themed icons.

[M123-dev]

I am open to this, but we can of course keep the splash generator and remove the icon generator if one of them is missing features.

[monsieurtanuki]

Please do something that works and that flutter devs can maintain.

[monsieurtanuki]

I've just downloaded the app from the google play store.
That didn't go well:

[monsieurtanuki]

Then the camera froze, then switched to "always black" mode.
I tried to restart the app, but now it crashes systematically (I just have the splash screen).
But that's another story.

[teolemon]

• @monsieurtanuki @simonbengtsson I've created a separate issue on the topic.
• Also if I'm right, @g123k fixed a few things with the splashscreen already in fix: Splashscreen stretched on Android 21 & 22 #2826 and fix: Splash on Android 24 #2832 , so we might be able to move forward.

[simonbengtsson]

Great! Rebased against develop now in case we want to merge this.

[monsieurtanuki]

Hi @simonbengtsson!
As far as I understand iOS LaunchScreen storyboard, looks good to me.