Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: #2852 - Matomo message when barcode is not found #2854

Merged
merged 4 commits into from Aug 29, 2022

Conversation

monsieurtanuki
Copy link
Contributor

Impacted file:

  • barcode_product_query.dart: added Sentry message when barcode is not found

What

  • Added a Sentry message when barcode is not found (scan or not scan) (anyway it was a barcode search)
    barcode 99999888884 was not found (scan: false, language: OpenFoodFactsLanguage.FRENCH, country: OpenFoodFactsCountry.FRANCE)

Fixes bug(s)

Impacted file:
* `barcode_product_query.dart`: added Sentry message when barcode is not found
@monsieurtanuki monsieurtanuki requested a review from a team as a code owner August 28, 2022 15:16
@codecov-commenter
Copy link

codecov-commenter commented Aug 28, 2022

Codecov Report

Merging #2854 (c0989fe) into develop (903d3fc) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           develop   #2854      +/-   ##
==========================================
- Coverage     7.05%   7.04%   -0.01%     
==========================================
  Files          219     219              
  Lines        10864   10871       +7     
==========================================
  Hits           766     766              
- Misses       10098   10105       +7     
Impacted Files Coverage Δ
...kages/smooth_app/lib/helpers/analytics_helper.dart 0.00% <0.00%> (ø)
...es/smooth_app/lib/query/barcode_product_query.dart 0.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@teolemon
Copy link
Member

I meant Matomo, not Sentry,sorry :-/

Impacted files:
* `analytics_helper.dart`: new method about barcode not found; fixed typos
* `barcode_product_query.dart`: added Matomo (and not Sentry) message when barcode is not found
@monsieurtanuki
Copy link
Contributor Author

@teolemon Now it's Matomo.

@monsieurtanuki monsieurtanuki changed the title feat: #2852 - Sentry message when barcode is not found feat: #2852 - Matomo message when barcode is not found Aug 29, 2022
@monsieurtanuki monsieurtanuki merged commit 3dca648 into openfoodfacts:develop Aug 29, 2022
@monsieurtanuki monsieurtanuki mentioned this pull request Aug 29, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Log whenever people encounter an unknown product using Matomo
3 participants