fix: #2833 - KP page refreshed by product (refactoring was needed) #2861
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as needed) Impacted files: * `knowledge_panel_card.dart`: refactored the call to `KnowledgePanelPage` * `knowledge_panel_element_card.dart`: refactored the calls to `KnowledgePanelCard` and `KnowledgePanelGroupCard` * `knowledge_panel_expanded_card.dart`: refactored the call to `KnowledgePanelElementCard` * `knowledge_panel_group_card.dart`: refactored the call to `KnowledgePanelCard` * `knowledge_panel_page.dart`: refactored the call to `KnowledgePanelExpandedCard`; we use a `Consumer` in order to refresh when the product is refreshed * `knowledge_panel_page_template.dart`; refactored the call to `KnowledgePanelWidget` * `knowledge_panels_builder.dart`: refactored the call to `KnowledgePanelElementCard` * `new_product_page.dart`: refactored the call to `KnowledgePanelWidget` * `simple_input_page.dart`: unrelated "vertical axis" for verbose buttons * `summary_card.dart`: refactored the call to `KnowledgePanelPage`
5 tasks
Codecov Report
@@ Coverage Diff @@
## develop #2861 +/- ##
==========================================
- Coverage 6.94% 6.94% -0.01%
==========================================
Files 229 229
Lines 11155 11156 +1
==========================================
Hits 775 775
- Misses 10380 10381 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
M123-dev
approved these changes
Sep 7, 2022
|
Thank you @M123-dev! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
knowledge_panel_card.dart: refactored the call toKnowledgePanelPageknowledge_panel_element_card.dart: refactored the calls toKnowledgePanelCardandKnowledgePanelGroupCardknowledge_panel_expanded_card.dart: refactored the call toKnowledgePanelElementCardknowledge_panel_group_card.dart: refactored the call toKnowledgePanelCardknowledge_panel_page.dart: refactored the call toKnowledgePanelExpandedCard; we use aConsumerin order to refresh when the product is refreshedknowledge_panel_page_template.dart; refactored the call toKnowledgePanelWidgetknowledge_panels_builder.dart: refactored the call toKnowledgePanelElementCardnew_product_page.dart: refactored the call toKnowledgePanelWidgetsimple_input_page.dart: unrelated "vertical axis" for verbose buttonssummary_card.dart: refactored the call toKnowledgePanelPageWhat
String panelId.Screenshot
While fixing the issue, I also improved a dialog display:
Fixes bug(s)