Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⛔️ DO NOT release any version based on Flutter 3.3 #2919

Closed
g123k opened this issue Sep 4, 2022 · 14 comments · Fixed by #3151
Closed

⛔️ DO NOT release any version based on Flutter 3.3 #2919

g123k opened this issue Sep 4, 2022 · 14 comments · Fixed by #3151
Assignees
Labels
🐛 bug Something isn't working 🎯 P0

Comments

@g123k
Copy link
Collaborator

g123k commented Sep 4, 2022

On the official Flutter GitHub, many issues are reported about regressions with Flutter 3.3.
Please DO not release any public version until a fix is released.

Here are the issues, that I'm able to reproduce:

@g123k g123k changed the title Don't release any version based on Flutter 3.3 ⛔️ DO NOT release any version based on Flutter 3.3 Sep 4, 2022
@M123-dev M123-dev added 🎯 P0 🐛 bug Something isn't working labels Sep 4, 2022
@M123-dev
Copy link
Member

M123-dev commented Sep 4, 2022

Just checked the last releases, v3.8.1 is the last one before 3.3.0 @teolemon

@monsieurtanuki
Copy link
Contributor

I suggest that we downgrade to 3.0.5 (actually I did not upgrade), specifically for a version that does not bring interesting features, as @g123k explained.
We also had a similar problem this week with an upgrade of mlkit.
In general, as I mentioned earlier, we could avoid jumping on every new version of the 50+ packages we use. If needed, that may mean strict version numbers in pubspec.yaml (no ^ I guess). And controlled upgrades once in a while.

@g123k
Copy link
Collaborator Author

g123k commented Sep 4, 2022

I suggest that we downgrade to 3.0.5 (actually I did not upgrade), specifically for a version that does not bring interesting features, as @g123k explained. We also had a similar problem this week with an upgrade of mlkit. In general, as I mentioned earlier, we could avoid jumping on every new version of the 50+ packages we use. If needed, that may mean strict version numbers in pubspec.yaml (no ^ I guess). And controlled upgrades once in a while.

I strongly agree with this change, but will Dependabot still work with strict versions?
Being notified of new releases (like bug fixes) would still be interesting.

@monsieurtanuki
Copy link
Contributor

I'm ready to downgrade the code and "fix" the pubspec.yaml.
But that means that flutter 3.0.5 needs to be used by the CI bots - if not the code would be rejected. @M123-dev @teolemon?

Being notified of new releases (like bug fixes) would still be interesting.

Indeed we need to find a process. But it's not like we currently used 50+ packages full of bugs: most of them are 100% functional. We can do the upgrade smoothly (and manually), with a focus on specific packages. With no rush.

@M123-dev
Copy link
Member

M123-dev commented Sep 5, 2022

CI isn't a problem should be one parameter per workflow don't worry about that

@g123k
Copy link
Collaborator Author

g123k commented Sep 7, 2022

The new version of Flutter (3.3.1) doesn’t fix any issues related to the text rendering. We continue with 3.0.

@nimr77
Copy link

nimr77 commented Sep 8, 2022

totally agree, this version doesn't have any interesting features and it has bugs while rendering.

@lsaudon
Copy link
Contributor

lsaudon commented Sep 13, 2022

The patches have been made but no version yet.
Surely the next version will have them.

@purgeyao
Copy link

flutter/flutter#105014 It doesn't seem to have been fixed

@g123k
Copy link
Collaborator Author

g123k commented Sep 15, 2022

It's now OK to migrate back to 3.3.x, as 3.3.2 fixes the text's issue

@M123-dev M123-dev self-assigned this Sep 15, 2022
@M123-dev
Copy link
Member

We decided to upgrade to not have to upgrade multiple versions in the future. But not a high priority

@monsieurtanuki
Copy link
Contributor

@M123-dev Unfortunately the upgrade has an impact on the code.
So, which version should we upgrade to, and when? Possible answer: we'll think about it again on [specify a date].
For the record I'm part of the 25% of developers that do not rush when there's a new version, according to a recent poll :)

@g123k
Copy link
Collaborator Author

g123k commented Oct 13, 2022

I think it should now be OK to upgrade to Flutter 3.3.
Otherwise we will have two versions to upgrade on the next Flutter major release.

@monsieurtanuki
Copy link
Contributor

I guess we can reasonably switch to flutter 3.3.4, as it's already the 5th version of 3.3 - they probably fixed most bugs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working 🎯 P0
Development

Successfully merging a pull request may close this issue.

6 participants