Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pull to refresh exception #3124

Merged
merged 8 commits into from Oct 11, 2022
Merged

fix: Pull to refresh exception #3124

merged 8 commits into from Oct 11, 2022

Conversation

prathamsoni11
Copy link
Contributor

What

Screenshot

Screenshot_2022-10-11-19-02-01-154_org openfoodfacts scanner

Fixes bug(s)

Part of

@prathamsoni11 prathamsoni11 requested a review from a team as a code owner October 11, 2022 13:33
monsieurtanuki
monsieurtanuki approved these changes Oct 11, 2022
View reviewed changes
Copy link
Contributor

@monsieurtanuki monsieurtanuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @prathamsoni11!
Actually you don't have to put the // added comments, it was just for issue's understanding but we cannot afford to keep all layers of PR comments.
In addition to that, github complains that the code is not correctly formatted (maybe because of the // added comments, maybe because of the try additional spaces.

packages/smooth_app/lib/pages/product/common/product_refresher.dart Outdated Show resolved Hide resolved
packages/smooth_app/lib/pages/product/common/product_refresher.dart Outdated Show resolved Hide resolved
@monsieurtanuki monsieurtanuki merged commit 012a67f into openfoodfacts:develop Oct 11, 2022
@prathamsoni11
Copy link
Contributor Author

Hi @prathamsoni11!
Actually you don't have to put the // added comments, it was just for the issue's understanding but we cannot afford to keep all layers of PR comments.
In addition to that, GitHub complains that the code is not correctly formatted (maybe because of the // added comments, maybe because of the try additional spaces.

Sorry i didn't know about it next time I will keep it in mind.

@monsieurtanuki monsieurtanuki mentioned this pull request Oct 11, 2022
Closed
@monsieurtanuki
Copy link
Contributor

Thank you @prathamsoni11!

@github-actions github-actions bot mentioned this pull request Oct 13, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monsieurtanuki monsieurtanuki monsieurtanuki approved these changes

Assignees

@prathamsoni11 prathamsoni11

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@prathamsoni11 @monsieurtanuki